From 7e663f8bcf04e58005aae7233313e607ee91aae0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Javi=20Mart=C3=ADn?= Date: Mon, 13 Jun 2022 16:06:17 +0200 Subject: [PATCH 1/2] Fix spacing issues after removing lines Rubocop was complaining about a Layout/ExtraSpacing in a couple of places. These issues weren't detected by Pronto because they didn't affect lines changed in the pull request. These lines were fine until we removed the lines next to them in commits 4b42a68b6 and 00f0c4410. --- spec/models/abilities/common_spec.rb | 2 +- spec/system/legislation/processes_spec.rb | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/spec/models/abilities/common_spec.rb b/spec/models/abilities/common_spec.rb index 44ddb5e15..42194209a 100644 --- a/spec/models/abilities/common_spec.rb +++ b/spec/models/abilities/common_spec.rb @@ -289,7 +289,7 @@ describe Abilities::Common do before { user.update(verified_at: Time.current) } - it { should be_able_to(:vote, Proposal) } + it { should be_able_to(:vote, Proposal) } it { should be_able_to(:new, DirectMessage) } it { should be_able_to(:create, DirectMessage) } diff --git a/spec/system/legislation/processes_spec.rb b/spec/system/legislation/processes_spec.rb index 7304fc543..406cec2cf 100644 --- a/spec/system/legislation/processes_spec.rb +++ b/spec/system/legislation/processes_spec.rb @@ -254,7 +254,7 @@ describe "Legislation" do expect(page).to have_content("Homepage") end - expect(page).to have_content("This is the process homepage") + expect(page).to have_content("This is the process homepage") end scenario "disabled", :with_frozen_time do @@ -280,7 +280,7 @@ describe "Legislation" do visit legislation_process_path(process) - expect(page).to have_content("This phase is not open yet") + expect(page).to have_content("This phase is not open yet") end scenario "open without questions" do From f5de0a6102616cf0669a3040e6ca5acc0b2bf332 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Javi=20Mart=C3=ADn?= Date: Mon, 13 Jun 2022 16:11:24 +0200 Subject: [PATCH 2/2] Add empty line after access modifier Rubocop was complaining about Layout/EmptyLinesAroundAccessModifier in the tags controller. This issue was introduced in commit e76735031. Unfortunately, it looks like Pronto doesn't detect this issue because the access modifier was already there; only the lines below it were introduced in that pull request. --- app/controllers/admin/tags_controller.rb | 1 + 1 file changed, 1 insertion(+) diff --git a/app/controllers/admin/tags_controller.rb b/app/controllers/admin/tags_controller.rb index 0dd52039e..4353c8ce4 100644 --- a/app/controllers/admin/tags_controller.rb +++ b/app/controllers/admin/tags_controller.rb @@ -26,6 +26,7 @@ class Admin::TagsController < Admin::BaseController end private + def tags @tags ||= Tag.category.page(params[:page]) end