Remove unnecessary specs

All these types of tests have already been grouped together in the
comments_specs file which contains different factories including
budget_investments.

I don't think it is necessary to maintain these tests.

spec/system/comments/budget_investments_valuation_spec.rb

@@ -57,112 +57,6 @@ describe "Internal valuation comments on Budget::Investments" do
         expect(page).to     have_content("Valuator Valuation response")
       end
     end
-
-    scenario "Collapsable comments" do
-      parent_comment = create(:comment, :valuation, author: valuator_user, body: "Main comment",
-                                                    commentable: investment)
-      child_comment  = create(:comment, :valuation, author: valuator_user, body: "First subcomment",
-                                                    commentable: investment, parent: parent_comment)
-      grandchild_comment = create(:comment, :valuation, author: valuator_user,
-                                                        parent: child_comment,
-                                                        body: "Last child",
-                                                        commentable: investment)
-
-      visit valuation_budget_budget_investment_path(budget, investment)
-
-      expect(page).to have_css(".comment", count: 3)
-      expect(page).to have_content("1 response (collapse)", count: 2)
-
-      within ".comment .comment", text: "First subcomment" do
-        click_link text: "1 response (collapse)"
-      end
-
-      expect(page).to have_css(".comment", count: 2)
-      expect(page).to have_content("1 response (collapse)")
-      expect(page).to have_content("1 response (show)")
-      expect(page).not_to have_content grandchild_comment.body
-
-      within ".comment .comment", text: "First subcomment" do
-        click_link text: "1 response (show)"
-      end
-
-      expect(page).to have_css(".comment", count: 3)
-      expect(page).to have_content("1 response (collapse)", count: 2)
-      expect(page).to have_content grandchild_comment.body
-
-      within ".comment", text: "Main comment" do
-        click_link text: "1 response (collapse)", match: :first
-      end
-
-      expect(page).to have_css(".comment", count: 1)
-      expect(page).to have_content("1 response (show)")
-      expect(page).not_to have_content child_comment.body
-      expect(page).not_to have_content grandchild_comment.body
-    end
-
-    scenario "Comment order" do
-      create(:comment, :valuation, commentable: investment,
-                                   author: valuator_user,
-                                   body: "Valuator Valuation",
-                                   created_at: Time.current - 1)
-      admin_valuation = create(:comment, :valuation, commentable: investment,
-                                                     author: admin_user,
-                                                     body: "Admin Valuation",
-                                                     created_at: Time.current - 2)
-
-      visit valuation_budget_budget_investment_path(budget, investment)
-
-      expect(admin_valuation.body).to appear_before("Valuator Valuation")
-    end
-
-    scenario "Turns links into html links" do
-      create(:comment, :valuation, author: admin_user, commentable: investment,
-                                   body: "Check http://rubyonrails.org/")
-
-      visit valuation_budget_budget_investment_path(budget, investment)
-
-      within first(".comment") do
-        expect(page).to have_content("Check http://rubyonrails.org/")
-        expect(page).to have_link("http://rubyonrails.org/", href: "http://rubyonrails.org/")
-        expect(find_link("http://rubyonrails.org/")[:rel]).to eq("nofollow")
-        expect(find_link("http://rubyonrails.org/")[:target]).to be_blank
-      end
-    end
-
-    scenario "Sanitizes comment body for security" do
-      comment_with_js = "<script>alert('hola')</script> <a href=\"javascript:alert('sorpresa!')\">" \
-                        "click me<a/> http://www.url.com"
-      create(:comment, :valuation, author: admin_user, commentable: investment,
-                                   body: comment_with_js)
-
-      visit valuation_budget_budget_investment_path(budget, investment)
-
-      within first(".comment") do
-        expect(page).to have_content("click me http://www.url.com")
-        expect(page).to have_link("http://www.url.com", href: "http://www.url.com")
-        expect(page).not_to have_link("click me")
-      end
-    end
-
-    scenario "Paginated comments" do
-      per_page = 10
-      (per_page + 2).times do
-        create(:comment, :valuation, commentable: investment, author: valuator_user)
-      end
-
-      visit valuation_budget_budget_investment_path(budget, investment)
-
-      expect(page).to have_css(".comment", count: per_page)
-      within("ul.pagination") do
-        expect(page).to have_content("1")
-        expect(page).to have_content("2")
-        expect(page).not_to have_content("3")
-        click_link "Next", exact: false
-      end
-
-      expect(page).to have_css(".comment", count: 2)
-      expect(page).to have_current_path(/#comments/, url: true)
-    end
   end
 
   context "Valuation comment creation" do
@@ -186,14 +80,6 @@ describe "Internal valuation comments on Budget::Investments" do
       expect(page).not_to have_content("Have you thought about...?")
     end
 
-    scenario "Errors on create without comment text" do
-      visit valuation_budget_budget_investment_path(budget, investment)
-
-      click_button "Publish comment"
-
-      expect(page).to have_content "Can't be blank"
-    end
-
     scenario "Reply to existing valuation" do
       comment = create(:comment, :valuation, author: admin_user, commentable: investment)
 
@@ -217,51 +103,6 @@ describe "Internal valuation comments on Budget::Investments" do
       expect(page).not_to have_content("It will be done next week.")
     end
 
-    scenario "Reply update parent comment responses count" do
-      comment = create(:comment, :valuation, author: admin_user, commentable: investment)
-
-      login_as(valuator_user)
-      visit valuation_budget_budget_investment_path(budget, investment)
-
-      within ".comment", text: comment.body do
-        click_link "Reply"
-        fill_in "Leave your comment", with: "It will be done next week."
-        click_button "Publish reply"
-
-        expect(page).to have_content("1 response (collapse)")
-      end
-    end
-
-    scenario "Reply show parent comments responses when hidden" do
-      comment = create(:comment, :valuation, author: admin_user, commentable: investment)
-      create(:comment, :valuation, author: admin_user, commentable: investment, parent: comment)
-
-      login_as(valuator_user)
-      visit valuation_budget_budget_investment_path(budget, investment)
-
-      within ".comment", text: comment.body do
-        click_link text: "1 response (collapse)"
-        click_link "Reply"
-        fill_in "Leave your comment", with: "It will be done next week."
-        click_button "Publish reply"
-
-        expect(page).to have_content("It will be done next week.")
-      end
-    end
-
-    scenario "Errors on reply without comment text" do
-      comment = create(:comment, :valuation, author: admin_user, commentable: investment)
-
-      visit valuation_budget_budget_investment_path(budget, investment)
-
-      click_link "Reply"
-
-      within "#js-comment-form-comment_#{comment.id}" do
-        click_button "Publish reply"
-        expect(page).to have_content "Can't be blank"
-      end
-    end
-
     scenario "Multiple nested replies" do
       parent = create(:comment, :valuation, author: valuator_user, commentable: investment)
 
@@ -279,18 +120,6 @@ describe "Internal valuation comments on Budget::Investments" do
     end
   end
 
-  scenario "Erasing a comment's author" do
-    comment = create(:comment, :valuation, author: valuator_user, commentable: investment,
-                                           body: "this should be visible")
-    comment.user.erase
-
-    visit valuation_budget_budget_investment_path(budget, investment)
-    within "#comment_#{comment.id}" do
-      expect(page).to have_content("User deleted")
-      expect(page).to have_content("this should be visible")
-    end
-  end
-
   describe "Administrators" do
     scenario "can create valuation comment as an administrator" do
       login_as(admin_user)