From 68285aae06c6b4fb1a4cb15b4534a3af4ae6fcc3 Mon Sep 17 00:00:00 2001
From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com>
Date: Mon, 18 Mar 2024 19:41:35 +0000
Subject: [PATCH] Bump rubocop-performance from 1.19.1 to 1.20.2

Note we're removing the Performance/StringIdentifierArgument rule
because now it also replaces methods in interpolation, and we don't
particularly prefer using `send(:"#{method}_name")` over
`send("#{method}_name)`. We actually use the latter about two thirds of
the time.

We'll add this rule again if it ever offers the option to ignore the
cases where interpolation is used, although it's highly doubtful that'll
ever happen because this rule is meant for (insignificant) performance
gains and not for code clarity.

Bumps [rubocop-performance](https://github.com/rubocop/rubocop-performance) from 1.19.1 to 1.20.2.
- [Release notes](https://github.com/rubocop/rubocop-performance/releases)
- [Changelog](https://github.com/rubocop/rubocop-performance/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rubocop/rubocop-performance/compare/v1.19.1...v1.20.2)

---
updated-dependencies:
- dependency-name: rubocop-performance
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
---
 .rubocop.yml |  3 ---
 Gemfile      |  2 +-
 Gemfile.lock | 10 +++++-----
 3 files changed, 6 insertions(+), 9 deletions(-)

diff --git a/.rubocop.yml b/.rubocop.yml
index 11a007c5d..2eff505bf 100644
--- a/.rubocop.yml
+++ b/.rubocop.yml
@@ -352,9 +352,6 @@ Performance/EndWith:
 Performance/StartWith:
   Enabled: true
 
-Performance/StringIdentifierArgument:
-  Enabled: true
-
 Performance/Sum:
   Enabled: true
 
diff --git a/Gemfile b/Gemfile
index 6ed460739..6b027727a 100644
--- a/Gemfile
+++ b/Gemfile
@@ -107,7 +107,7 @@ group :development do
   gem "rubocop", "~> 1.56.4", require: false
   gem "rubocop-capybara", "~> 2.20.0", require: false
   gem "rubocop-factory_bot", "~> 2.25.1", require: false
-  gem "rubocop-performance", "~> 1.19.1", require: false
+  gem "rubocop-performance", "~> 1.20.2", require: false
   gem "rubocop-rails", "~> 2.23.1", require: false
   gem "rubocop-rspec", "~> 2.27.0", require: false
   gem "rvm1-capistrano3", "~> 1.4.0", require: false
diff --git a/Gemfile.lock b/Gemfile.lock
index 84f111a93..b58bd8214 100644
--- a/Gemfile.lock
+++ b/Gemfile.lock
@@ -539,15 +539,15 @@ GEM
       rubocop-ast (>= 1.28.1, < 2.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 2.4.0, < 3.0)
-    rubocop-ast (1.31.1)
+    rubocop-ast (1.31.2)
       parser (>= 3.3.0.4)
     rubocop-capybara (2.20.0)
       rubocop (~> 1.41)
     rubocop-factory_bot (2.25.1)
       rubocop (~> 1.41)
-    rubocop-performance (1.19.1)
-      rubocop (>= 1.7.0, < 2.0)
-      rubocop-ast (>= 0.4.0)
+    rubocop-performance (1.20.2)
+      rubocop (>= 1.48.1, < 2.0)
+      rubocop-ast (>= 1.30.0, < 2.0)
     rubocop-rails (2.23.1)
       activesupport (>= 4.2.0)
       rack (>= 1.1)
@@ -767,7 +767,7 @@ DEPENDENCIES
   rubocop (~> 1.56.4)
   rubocop-capybara (~> 2.20.0)
   rubocop-factory_bot (~> 2.25.1)
-  rubocop-performance (~> 1.19.1)
+  rubocop-performance (~> 1.20.2)
   rubocop-rails (~> 2.23.1)
   rubocop-rspec (~> 2.27.0)
   rvm1-capistrano3 (~> 1.4.0)