consul/grecia
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Add feature specs to check that edit links and "Selected" buttons are not displayed/enabled.

Browse Source 
"Selected" button appears as text instead of dissapearing completely.
This commit is contained in:
iagirre
2017-12-27 16:23:21 +01:00
parent ec8715efd3
commit 64aaa97d86
2 changed files with 78 additions and 45 deletions
Download Patch File Download Diff File Expand all files Collapse all files

40
app/views/admin/budget_investments/_investments.html.erb
View File

@@ -55,28 +55,24 @@
<%= investment.valuation_finished? ? t('shared.yes'): t('shared.no') %> <%= investment.valuation_finished? ? t('shared.yes'): t('shared.no') %>
</td> </td>
<td class="small"> <td class="small">
<% unless investment.budget.finished? %> <% if investment.selected? %>
<% if investment.selected? %> <%= link_to_unless investment.budget.finished?, t("admin.budget_investments.index.selected"),
<%= link_to toggle_selection_admin_budget_budget_investment_path(@budget, toggle_selection_admin_budget_budget_investment_path(@budget,
investment, investment,
filter: params[:filter], filter: params[:filter],
page: params[:page]), page: params[:page]),
method: :patch, method: :patch,
remote: true, remote: true,
class: "button small expanded" do %> class: "button small expanded" %>
<%= t("admin.budget_investments.index.selected") %> <% elsif investment.feasible? && investment.valuation_finished? %>
<% end %> <%= link_to_unless investment.budget.finished?, t("admin.budget_investments.index.select"),
<% elsif investment.feasible? && investment.valuation_finished? %> toggle_selection_admin_budget_budget_investment_path(@budget,
<%= link_to toggle_selection_admin_budget_budget_investment_path(@budget, investment,
investment, filter: params[:filter],
filter: params[:filter], page: params[:page]),
page: params[:page]), method: :patch,
method: :patch, remote: true,
remote: true, class: "button small hollow expanded" %>
class: "button small hollow expanded" do %>
<%= t("admin.budget_investments.index.select") %>
<% end %>
<% end %>
<% end %> <% end %>
</td> </td>
<% if params[:filter] == 'selected' %> <% if params[:filter] == 'selected' %>

83
spec/features/admin/budget_investments_spec.rb
View File

@@ -36,6 +36,21 @@ feature 'Admin budget investments' do
expect(page).to have_content(budget_investment.total_votes) expect(page).to have_content(budget_investment.total_votes)
end end
scenario 'If budget is finished do not show "Selected" button' do
finished_budget = create(:budget, :finished)
budget_investment = create(:budget_investment, budget: finished_budget, cached_votes_up: 77)
visit admin_budget_budget_investments_path(budget_id: finished_budget.id)
within("#budget_investment_#{budget_investment.id}") do
expect(page).to have_content(budget_investment.title)
expect(page).to have_content(budget_investment.heading.name)
expect(page).to have_content(budget_investment.id)
expect(page).to have_content(budget_investment.total_votes)
expect(page).to_not have_link("Selected")
end
end
scenario 'Displaying assignments info' do scenario 'Displaying assignments info' do
budget_investment1 = create(:budget_investment, budget: @budget) budget_investment1 = create(:budget_investment, budget: @budget)
budget_investment2 = create(:budget_investment, budget: @budget) budget_investment2 = create(:budget_investment, budget: @budget)
@@ -279,33 +294,55 @@ feature 'Admin budget investments' do
end end
scenario 'Show' do context 'Show' do
administrator = create(:administrator, user: create(:user, username: 'Ana', email: 'ana@admins.org')) background do
valuator = create(:valuator, user: create(:user, username: 'Rachel', email: 'rachel@valuators.org')) @administrator = create(:administrator, user: create(:user, username: 'Ana', email: 'ana@admins.org'))
budget_investment = create(:budget_investment, end
price: 1234,
price_first_year: 1000,
feasibility: "unfeasible",
unfeasibility_explanation: 'It is impossible',
administrator: administrator)
budget_investment.valuators << valuator
visit admin_budget_budget_investments_path(budget_investment.budget) scenario 'Show the investment details' do
valuator = create(:valuator, user: create(:user, username: 'Rachel', email: 'rachel@valuators.org'))
budget_investment = create(:budget_investment,
price: 1234,
price_first_year: 1000,
feasibility: "unfeasible",
unfeasibility_explanation: 'It is impossible',
administrator: @administrator)
budget_investment.valuators << valuator
click_link budget_investment.title visit admin_budget_budget_investments_path(budget_investment.budget)
expect(page).to have_content(budget_investment.title) click_link budget_investment.title
expect(page).to have_content(budget_investment.description)
expect(page).to have_content(budget_investment.author.name)
expect(page).to have_content(budget_investment.heading.name)
expect(page).to have_content('1234')
expect(page).to have_content('1000')
expect(page).to have_content('Unfeasible')
expect(page).to have_content('It is impossible')
expect(page).to have_content('Ana (ana@admins.org)')
within('#assigned_valuators') do expect(page).to have_content(budget_investment.title)
expect(page).to have_content('Rachel (rachel@valuators.org)') expect(page).to have_content(budget_investment.description)
expect(page).to have_content(budget_investment.author.name)
expect(page).to have_content(budget_investment.heading.name)
expect(page).to have_content('1234')
expect(page).to have_content('1000')
expect(page).to have_content('Unfeasible')
expect(page).to have_content('It is impossible')
expect(page).to have_content('Ana (ana@admins.org)')
within('#assigned_valuators') do
expect(page).to have_content('Rachel (rachel@valuators.org)')
end
end
scenario "If budget is finished, investment cannot be edited" do
# Only milestones can be managed
finished_budget = create(:budget, :finished)
budget_investment = create(:budget_investment,
budget: finished_budget,
administrator: @administrator)
visit admin_budget_budget_investments_path(budget_investment.budget)
click_link budget_investment.title
expect(page).to_not have_link "Edit"
expect(page).to_not have_link "Edit classification"
expect(page).to_not have_link "Edit dossier"
expect(page).to have_link "Create new milestone"
end end
end end