consul/grecia
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix text to subscribe to a newsletter

Browse Source 
In English, circumstancial complements usually go after the direct
complement.
This commit is contained in:
Javi Martín
2022-04-01 16:33:13 +02:00
parent 4ddcfb2f2a
commit 647a7dc435
4 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
config/locales/en/activerecord.yml
View File

@@ -276,7 +276,7 @@ en:
email_on_comment: "Notify me by email when someone comments on my contents" email_on_comment: "Notify me by email when someone comments on my contents"
email_on_comment_reply: "Notify me by email when someone replies to my comments" email_on_comment_reply: "Notify me by email when someone replies to my comments"
email_on_direct_message: "Receive emails about direct messages" email_on_direct_message: "Receive emails about direct messages"
newsletter: "Receive by email website relevant information" newsletter: "Receive relevant information by email"
official_position: "Official position" official_position: "Official position"
official_position_badge: "Show official position badge" official_position_badge: "Show official position badge"
official_level: "Official level" official_level: "Official level"

2
spec/components/subscriptions/edit_component_spec.rb
View File

@@ -10,7 +10,7 @@ describe Subscriptions::EditComponent do
expect(page).to have_content "Notifications" expect(page).to have_content "Notifications"
expect(page).to have_field "Notify me by email when someone comments on my contents", type: :checkbox expect(page).to have_field "Notify me by email when someone comments on my contents", type: :checkbox
expect(page).to have_field "Notify me by email when someone replies to my comments", type: :checkbox expect(page).to have_field "Notify me by email when someone replies to my comments", type: :checkbox
expect(page).to have_field "Receive by email website relevant information", type: :checkbox expect(page).to have_field "Receive relevant information by email", type: :checkbox
expect(page).to have_field "Receive a summary of proposal notifications", type: :checkbox expect(page).to have_field "Receive a summary of proposal notifications", type: :checkbox
expect(page).to have_field "Receive emails about direct messages", type: :checkbox expect(page).to have_field "Receive emails about direct messages", type: :checkbox
expect(page).to have_button "Save changes" expect(page).to have_button "Save changes"

2
spec/system/emails_spec.rb
View File

@@ -497,7 +497,7 @@ describe "Emails" do
expect(email).to have_body_text("To unsubscribe from these emails, visit") expect(email).to have_body_text("To unsubscribe from these emails, visit")
expect(email).to have_body_text( expect(email).to have_body_text(
edit_subscriptions_path(token: user_with_newsletter_in_segment_2.subscriptions_token)) edit_subscriptions_path(token: user_with_newsletter_in_segment_2.subscriptions_token))
expect(email).to have_body_text('and uncheck "Receive by email website relevant information"') expect(email).to have_body_text('and uncheck "Receive relevant information by email"')
end end
end end

4
spec/system/subscriptions_spec.rb
View File

@@ -35,7 +35,7 @@ describe "Subscriptions" do
check "Notify me by email when someone comments on my contents" check "Notify me by email when someone comments on my contents"
uncheck "Notify me by email when someone replies to my comments" uncheck "Notify me by email when someone replies to my comments"
uncheck "Receive by email website relevant information" uncheck "Receive relevant information by email"
check "Receive a summary of proposal notifications" check "Receive a summary of proposal notifications"
uncheck "Receive emails about direct messages" uncheck "Receive emails about direct messages"
click_button "Save changes" click_button "Save changes"
@@ -43,7 +43,7 @@ describe "Subscriptions" do
expect(page).to have_content "Changes saved" expect(page).to have_content "Changes saved"
expect(page).to have_field "Notify me by email when someone comments on my contents", checked: true expect(page).to have_field "Notify me by email when someone comments on my contents", checked: true
expect(page).to have_field "Notify me by email when someone replies to my comments", checked: false expect(page).to have_field "Notify me by email when someone replies to my comments", checked: false
expect(page).to have_field "Receive by email website relevant information", checked: false expect(page).to have_field "Receive relevant information by email", checked: false
expect(page).to have_field "Receive a summary of proposal notifications", checked: true expect(page).to have_field "Receive a summary of proposal notifications", checked: true
expect(page).to have_field "Receive emails about direct messages", checked: false expect(page).to have_field "Receive emails about direct messages", checked: false
end end