From 62b2f4812bc3e3504dd7f8e3bc0d7dfbf27ce1ab Mon Sep 17 00:00:00 2001 From: rgarcia Date: Sun, 14 May 2017 11:38:05 +0200 Subject: [PATCH] fixes false positive when storing previous heading id --- app/models/budget/investment.rb | 2 +- spec/models/budget/investment_spec.rb | 4 ++++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/app/models/budget/investment.rb b/app/models/budget/investment.rb index fbc03f467..b86cc2518 100644 --- a/app/models/budget/investment.rb +++ b/app/models/budget/investment.rb @@ -255,7 +255,7 @@ class Budget end def log_reclassification - self.previous_heading_id = self.heading_id_was + update_column(:previous_heading_id, heading_id_was) end def remove_reclassified_votes diff --git a/spec/models/budget/investment_spec.rb b/spec/models/budget/investment_spec.rb index 6486070bf..6010d5f5a 100644 --- a/spec/models/budget/investment_spec.rb +++ b/spec/models/budget/investment_spec.rb @@ -715,9 +715,13 @@ describe Budget::Investment do it "stores the previous heading before being reclassified" do investment = create(:budget_investment, heading: heading1) + expect(investment.heading_id).to eq(heading1.id) + expect(investment.previous_heading_id).to eq(nil) + investment.heading = heading2 investment.save + investment.reload expect(investment.heading_id).to eq(heading2.id) expect(investment.previous_heading_id).to eq(heading1.id) end