From 60b3ca000a9b8946a6ba94e298eb1b4a53f6f6ec Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Javi=20Mart=C3=ADn?= <javim@elretirao.net>
Date: Thu, 26 Nov 2020 12:50:53 +0100
Subject: [PATCH] Fix typos in admin menu classes

The HTML `class` attribute was declared twice and so the second one was
being ignored.

In the case of messages, it was "working" properly because the
`class=is-active` part is not used on `<li>` tags when they've got a
`<ul>` inside them.
---
 app/components/admin/menu_component.html.erb | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/app/components/admin/menu_component.html.erb b/app/components/admin/menu_component.html.erb
index 5c2d3edd2..4abcb3aa6 100644
--- a/app/components/admin/menu_component.html.erb
+++ b/app/components/admin/menu_component.html.erb
@@ -90,13 +90,12 @@
   <% end %>
 
   <% messages_sections = %w[newsletters emails_download admin_notifications system_emails] %>
-  <% messages_menu_active = messages_sections.include?(controller_name) %>
-  <li class="section-title" <%= "class=is-active" if messages_menu_active %>>
+  <li class="section-title">
     <a href="#">
       <span class="icon-zip"></span>
       <strong><%= t("admin.menu.messaging_users") %></strong>
     </a>
-    <ul id="messaging_users_menu" <%= "class=is-active" if messages_menu_active %>>
+    <ul id="messaging_users_menu" <%= "class=is-active" if messages_sections.include?(controller_name) %>>
       <li <%= "class=is-active" if controller_name == "newsletters" %>>
         <%= link_to t("admin.menu.newsletters"), admin_newsletters_path %>
       </li>
@@ -221,7 +220,7 @@
     </ul>
   </li>
 
-  <li class="section-title" <%= "class=is-active" if controller_name == "stats" %>>
+  <li class="section-title <%= "is-active" if controller_name == "stats" %>">
     <%= link_to admin_stats_path do %>
       <span class="icon-stats"></span><%= t("admin.menu.stats") %>
     <% end %>