From 5ab1ed57ea320330cbd98ea8b89aa90e2474bb0c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Javi=20Mart=C3=ADn?= <javim@elretirao.net>
Date: Sat, 27 Mar 2021 16:44:32 +0100
Subject: [PATCH] Simplify selector in tracking test

Using `have_selector` makes the test more robust since it matches all
the following HTML:

* <div data-track-event-category=verification>
* <div data-track-event-category='verification'>
* <div data-track-event-category="verification">

Our former expectation only matched the first one.
---
 spec/system/tracks_spec.rb | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/spec/system/tracks_spec.rb b/spec/system/tracks_spec.rb
index ee79591b7..42dfe493c 100644
--- a/spec/system/tracks_spec.rb
+++ b/spec/system/tracks_spec.rb
@@ -47,8 +47,8 @@ describe "Tracking" do
       visit account_path
       click_link "Verify my account"
 
-      expect(page.html).to include "data-track-event-category=verification"
-      expect(page.html).to include "data-track-event-action=start_census"
+      expect(page).to have_selector "[data-track-event-category='verification']", visible: :all
+      expect(page).to have_selector "[data-track-event-action='start_census']", visible: :all
     end
 
     scenario "Verification: success census & start sms" do
@@ -64,8 +64,8 @@ describe "Tracking" do
       fill_in "sms_phone", with: "611111111"
       click_button "Send"
 
-      expect(page.html).to include "data-track-event-category=verification"
-      expect(page.html).to include "data-track-event-action=start_sms"
+      expect(page).to have_selector "[data-track-event-category='verification']", visible: :all
+      expect(page).to have_selector "[data-track-event-action='start_sms']", visible: :all
     end
 
     scenario "Verification: success sms" do
@@ -85,8 +85,8 @@ describe "Tracking" do
       fill_in "sms_confirmation_code", with: user.sms_confirmation_code
       click_button "Send"
 
-      expect(page.html).to include "data-track-event-category=verification"
-      expect(page.html).to include "data-track-event-action=success_sms"
+      expect(page).to have_selector "[data-track-event-category='verification']", visible: :all
+      expect(page).to have_selector "[data-track-event-action='success_sms']", visible: :all
     end
 
     scenario "Verification: letter" do
@@ -108,8 +108,8 @@ describe "Tracking" do
 
       click_link "Send me a letter with the code"
 
-      expect(page.html).to include "data-track-event-category=verification"
-      expect(page.html).to include "data-track-event-action=start_letter"
+      expect(page).to have_selector "[data-track-event-category='verification']", visible: :all
+      expect(page).to have_selector "[data-track-event-action='start_letter']", visible: :all
     end
   end
 end