From 5a84dcb534bcddce5bc49aee2e54aadcdc52ab5f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Javi=20Mart=C3=ADn?= Date: Sat, 28 Sep 2019 13:24:29 +0200 Subject: [PATCH] Rename `unfinished` trait to `open` So now it's more consistent with the name we use in the rest of the code. --- spec/factories/budgets.rb | 2 +- spec/features/admin/budget_investments_spec.rb | 2 +- spec/features/budgets/investments_spec.rb | 2 +- spec/models/budget/investment_spec.rb | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/spec/factories/budgets.rb b/spec/factories/budgets.rb index b1942cf08..177a55b43 100644 --- a/spec/factories/budgets.rb +++ b/spec/factories/budgets.rb @@ -121,7 +121,7 @@ FactoryBot.define do valuation_finished { true } end - trait :unfinished do + trait :open do valuation_finished { false } end diff --git a/spec/features/admin/budget_investments_spec.rb b/spec/features/admin/budget_investments_spec.rb index 5195c6c7e..165d991e9 100644 --- a/spec/features/admin/budget_investments_spec.rb +++ b/spec/features/admin/budget_investments_spec.rb @@ -334,7 +334,7 @@ describe "Admin budget investments" do valuator = create(:valuator, user: user) create(:budget_investment, :with_administrator, - :unfinished, + :open, title: "Investment without valuation", budget: budget, valuators: [valuator]) diff --git a/spec/features/budgets/investments_spec.rb b/spec/features/budgets/investments_spec.rb index 458ce0f10..551150c51 100644 --- a/spec/features/budgets/investments_spec.rb +++ b/spec/features/budgets/investments_spec.rb @@ -1259,7 +1259,7 @@ describe "Budget Investments" do scenario "Show (unfeasible budget investment with valuation not finished)" do investment = create(:budget_investment, :unfeasible, - :unfinished, + :open, budget: budget, heading: heading, unfeasibility_explanation: "Local government is not competent in this matter") diff --git a/spec/models/budget/investment_spec.rb b/spec/models/budget/investment_spec.rb index 960acb9bc..5c00c8a5e 100644 --- a/spec/models/budget/investment_spec.rb +++ b/spec/models/budget/investment_spec.rb @@ -1152,7 +1152,7 @@ describe Budget::Investment do describe "with under_valuation filter" do let(:params) { { advanced_filters: ["under_valuation"], budget_id: budget.id } } it "returns only investment under valuation" do - investment1 = create(:budget_investment, :with_administrator, :unfinished, :with_valuator, + investment1 = create(:budget_investment, :with_administrator, :open, :with_valuator, budget: budget) create(:budget_investment, :with_administrator, budget: budget) create(:budget_investment, budget: budget)