From 574bd87b087e5ace294268a6bcf4b6539653f1bc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Javi=20Mart=C3=ADn?= Date: Fri, 10 May 2019 14:24:56 +0200 Subject: [PATCH] Remove unused (and flaky) card code and its spec This code was introduced in commit 722a431b, but it stopped being used in commit 7657a0e0. The spec was failing sometimes because the method didn't order the records, but the spec checked the records returned in a certain order. Furthermore, the method `page` generated a potential conflict with kaminari's `page method. --- app/models/widget/card.rb | 6 ------ spec/models/widget/card_spec.rb | 14 -------------- 2 files changed, 20 deletions(-) diff --git a/app/models/widget/card.rb b/app/models/widget/card.rb index bbc87e33b..d433278a9 100644 --- a/app/models/widget/card.rb +++ b/app/models/widget/card.rb @@ -18,10 +18,4 @@ class Widget::Card < ApplicationRecord def self.body where(header: false, site_customization_page_id: nil).order(:created_at) end - - #add widget cards to custom pages - def self.page(page_id) - where(site_customization_page_id: page_id) - end - end diff --git a/spec/models/widget/card_spec.rb b/spec/models/widget/card_spec.rb index 85c489d22..5cc4238f5 100644 --- a/spec/models/widget/card_spec.rb +++ b/spec/models/widget/card_spec.rb @@ -36,18 +36,4 @@ describe Widget::Card do expect(Widget::Card.body).not_to include(page_card) end end - - describe "#custom page" do - - it "return cards for the custom pages" do - header = create(:widget_card, header: true) - card = create(:widget_card, header: false) - card1 = create(:widget_card, header: false, title: "Card 1", site_customization_page_id: 1) - card2 = create(:widget_card, header: false, title: "Card 2", site_customization_page_id: 1) - card3 = create(:widget_card, header: false, title: "Card 3", site_customization_page_id: 1) - - expect(Widget::Card.page(1)).to eq([card1, card2, card3]) - end - end - end \ No newline at end of file