From 53fa5271188584bc960017161b4497ce746b007d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Javi=20Mart=C3=ADn?= Date: Sat, 21 Sep 2019 14:57:12 +0200 Subject: [PATCH] Add `invisible_to_valuators` trait to investments Now the code is symmetrical since we also use `visible_to_valuators`. --- spec/factories/budgets.rb | 4 ++++ spec/features/admin/budget_investments_spec.rb | 6 +++--- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/spec/factories/budgets.rb b/spec/factories/budgets.rb index af8e7340c..a1b3e58fc 100644 --- a/spec/factories/budgets.rb +++ b/spec/factories/budgets.rb @@ -129,6 +129,10 @@ FactoryBot.define do visible_to_valuators { true } end + trait :invisible_to_valuators do + visible_to_valuators { false } + end + trait :incompatible do selected incompatible { true } diff --git a/spec/features/admin/budget_investments_spec.rb b/spec/features/admin/budget_investments_spec.rb index 08ebba901..32e695c45 100644 --- a/spec/features/admin/budget_investments_spec.rb +++ b/spec/features/admin/budget_investments_spec.rb @@ -1659,8 +1659,8 @@ describe "Admin budget investments" do end scenario "Showing the valuating checkbox" do - investment1 = create(:budget_investment, :with_administrator, budget: budget, visible_to_valuators: true) - investment2 = create(:budget_investment, :with_administrator, budget: budget, visible_to_valuators: false) + investment1 = create(:budget_investment, :with_administrator, :visible_to_valuators, budget: budget) + investment2 = create(:budget_investment, :with_administrator, :invisible_to_valuators, budget: budget) investment1.valuators << create(:valuator) investment2.valuators << create(:valuator) @@ -1737,8 +1737,8 @@ describe "Admin budget investments" do let!(:investment) do create(:budget_investment, :winner, + :visible_to_valuators, budget: budget, - visible_to_valuators: true, author: create(:user, username: "Jon Doe") ) end