From 5315f34c7292264d6ffb9ae7c94e6379cc633fed Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Javi=20Mart=C3=ADn?= Date: Tue, 9 Jun 2020 14:41:22 +0200 Subject: [PATCH] Remove Performance/Detect rubocop rule After upgrading the rubocop-performance gem, we're asked to change this code: milestones.select { |milestone| milestone.image.present? }.last To: milestones.reverse.find { |milestone| milestone.image.present? } IMHO the original code is easier to read, so the performance gain isn't worth it. --- .rubocop.yml | 3 --- 1 file changed, 3 deletions(-) diff --git a/.rubocop.yml b/.rubocop.yml index 5eb40177c..71ba33b0f 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -186,9 +186,6 @@ Lint/UselessAssignment: Performance/CompareWithBlock: Enabled: true -Performance/Detect: - Enabled: true - Performance/DoubleStartEndWith: Enabled: true