Add and apply Rails/SelectMap rule
This rule was introduced in rubocop-rails 2.21.0. Using `pluck` is easier to read.
This commit is contained in:
@@ -460,6 +460,9 @@ Rails/SaveBang:
|
|||||||
Enabled: true
|
Enabled: true
|
||||||
Severity: refactor
|
Severity: refactor
|
||||||
|
|
||||||
|
Rails/SelectMap:
|
||||||
|
Enabled: true
|
||||||
|
|
||||||
Rails/SkipsModelValidations:
|
Rails/SkipsModelValidations:
|
||||||
Enabled: true
|
Enabled: true
|
||||||
ForbiddenMethods:
|
ForbiddenMethods:
|
||||||
|
|||||||
@@ -7,7 +7,7 @@ class Admin::Poll::OfficerAssignmentsController < Admin::Poll::BaseController
|
|||||||
@officers = ::Poll::Officer
|
@officers = ::Poll::Officer
|
||||||
.includes(:user)
|
.includes(:user)
|
||||||
.order("users.username")
|
.order("users.username")
|
||||||
.where(id: @poll.officer_assignments.select(:officer_id).distinct.map(&:officer_id))
|
.where(id: @poll.officer_assignments.distinct.pluck(:officer_id))
|
||||||
.page(params[:page])
|
.page(params[:page])
|
||||||
.per(50)
|
.per(50)
|
||||||
end
|
end
|
||||||
|
|||||||
Reference in New Issue
Block a user