Add RSpec/ExcessiveDocstringSpacing rubocop rule
This rule was added in rubocop-rspec 2.5.0.
This commit is contained in:
@@ -505,6 +505,9 @@ RSpec/EmptyLineAfterExampleGroup:
|
|||||||
RSpec/ExampleWording:
|
RSpec/ExampleWording:
|
||||||
Enabled: true
|
Enabled: true
|
||||||
|
|
||||||
|
RSpec/ExcessiveDocstringSpacing:
|
||||||
|
Enabled: true
|
||||||
|
|
||||||
RSpec/FactoryBot/FactoryClassName:
|
RSpec/FactoryBot/FactoryClassName:
|
||||||
Enabled: true
|
Enabled: true
|
||||||
|
|
||||||
|
|||||||
@@ -10,7 +10,7 @@ describe Users::ConfirmationsController do
|
|||||||
expect { get :show, params: { token: "non_existent" } }.to raise_error ActiveRecord::RecordNotFound
|
expect { get :show, params: { token: "non_existent" } }.to raise_error ActiveRecord::RecordNotFound
|
||||||
end
|
end
|
||||||
|
|
||||||
it "returns a 422 code with a existent and used token " do
|
it "returns a 422 code with a existent and used token" do
|
||||||
user = create(:user, confirmation_token: "token1")
|
user = create(:user, confirmation_token: "token1")
|
||||||
|
|
||||||
get :show, params: { user: user, confirmation_token: "token1" }
|
get :show, params: { user: user, confirmation_token: "token1" }
|
||||||
@@ -18,7 +18,7 @@ describe Users::ConfirmationsController do
|
|||||||
expect(response).to have_http_status(:unprocessable_entity)
|
expect(response).to have_http_status(:unprocessable_entity)
|
||||||
end
|
end
|
||||||
|
|
||||||
it "redirect to sign_in page with a existent and not used token " do
|
it "redirect to sign_in page with a existent and not used token" do
|
||||||
user = create(:user, confirmation_token: "token1", confirmed_at: "")
|
user = create(:user, confirmation_token: "token1", confirmed_at: "")
|
||||||
|
|
||||||
get :show, params: { user: user, confirmation_token: "token1" }
|
get :show, params: { user: user, confirmation_token: "token1" }
|
||||||
|
|||||||
@@ -14,7 +14,7 @@ describe ScoreCalculator do
|
|||||||
expect(ScoreCalculator.hot_score(resource)).to eq 1
|
expect(ScoreCalculator.hot_score(resource)).to eq 1
|
||||||
end
|
end
|
||||||
|
|
||||||
it "ignores setting with negative value " do
|
it "ignores setting with negative value" do
|
||||||
Setting["hot_score_period_in_days"] = -1
|
Setting["hot_score_period_in_days"] = -1
|
||||||
|
|
||||||
expect(ScoreCalculator.hot_score(resource)).to eq 1
|
expect(ScoreCalculator.hot_score(resource)).to eq 1
|
||||||
|
|||||||
@@ -170,7 +170,7 @@ describe Debate do
|
|||||||
expect { debate.register_vote(user, "yes") }.to change { debate.reload.votes_for.size }.by(1)
|
expect { debate.register_vote(user, "yes") }.to change { debate.reload.votes_for.size }.by(1)
|
||||||
end
|
end
|
||||||
|
|
||||||
it "does not increase anonymous votes counter " do
|
it "does not increase anonymous votes counter" do
|
||||||
user = create(:user, residence_verified_at: Time.current, confirmed_phone: "666333111")
|
user = create(:user, residence_verified_at: Time.current, confirmed_phone: "666333111")
|
||||||
expect { debate.register_vote(user, "yes") }.not_to change { debate.reload.total_anonymous_votes }
|
expect { debate.register_vote(user, "yes") }.not_to change { debate.reload.total_anonymous_votes }
|
||||||
end
|
end
|
||||||
@@ -182,7 +182,7 @@ describe Debate do
|
|||||||
expect { debate.register_vote(user, "yes") }.to change { debate.reload.votes_for.size }.by(1)
|
expect { debate.register_vote(user, "yes") }.to change { debate.reload.votes_for.size }.by(1)
|
||||||
end
|
end
|
||||||
|
|
||||||
it "does not increase anonymous votes counter " do
|
it "does not increase anonymous votes counter" do
|
||||||
user = create(:user, verified_at: Time.current)
|
user = create(:user, verified_at: Time.current)
|
||||||
expect { debate.register_vote(user, "yes") }.not_to change { debate.reload.total_anonymous_votes }
|
expect { debate.register_vote(user, "yes") }.not_to change { debate.reload.total_anonymous_votes }
|
||||||
end
|
end
|
||||||
@@ -205,12 +205,12 @@ describe Debate do
|
|||||||
describe "from anonymous users when there are too many anonymous votes" do
|
describe "from anonymous users when there are too many anonymous votes" do
|
||||||
before { debate.update(cached_anonymous_votes_total: 520, cached_votes_total: 1000) }
|
before { debate.update(cached_anonymous_votes_total: 520, cached_votes_total: 1000) }
|
||||||
|
|
||||||
it "does not register vote " do
|
it "does not register vote" do
|
||||||
user = create(:user)
|
user = create(:user)
|
||||||
expect { debate.register_vote(user, "yes") }.not_to change { debate.reload.votes_for.size }
|
expect { debate.register_vote(user, "yes") }.not_to change { debate.reload.votes_for.size }
|
||||||
end
|
end
|
||||||
|
|
||||||
it "does not increase anonymous votes counter " do
|
it "does not increase anonymous votes counter" do
|
||||||
user = create(:user)
|
user = create(:user)
|
||||||
expect { debate.register_vote(user, "yes") }.not_to change { debate.reload.total_anonymous_votes }
|
expect { debate.register_vote(user, "yes") }.not_to change { debate.reload.total_anonymous_votes }
|
||||||
end
|
end
|
||||||
|
|||||||
@@ -217,7 +217,7 @@ shared_examples_for "verifiable" do
|
|||||||
end
|
end
|
||||||
|
|
||||||
describe "#verification_sms_sent?" do
|
describe "#verification_sms_sent?" do
|
||||||
it "is true if skipped" do
|
it "is true if skipped" do
|
||||||
user.update!(unconfirmed_phone: nil, sms_confirmation_code: "666")
|
user.update!(unconfirmed_phone: nil, sms_confirmation_code: "666")
|
||||||
expect(user.verification_sms_sent?).to eq(true)
|
expect(user.verification_sms_sent?).to eq(true)
|
||||||
|
|
||||||
|
|||||||
@@ -8,7 +8,7 @@ describe "Admin download user emails" do
|
|||||||
login_as(admin_user)
|
login_as(admin_user)
|
||||||
end
|
end
|
||||||
|
|
||||||
context "Download only emails from segment users with newsletter flag & present email " do
|
context "Download only emails from segment users with newsletter flag & present email" do
|
||||||
before do
|
before do
|
||||||
create(:user, email: "user@consul.dev")
|
create(:user, email: "user@consul.dev")
|
||||||
|
|
||||||
|
|||||||
@@ -205,7 +205,7 @@ describe "Admin::Organizations" do
|
|||||||
expect(page).not_to have_content("Verified Organization")
|
expect(page).not_to have_content("Verified Organization")
|
||||||
end
|
end
|
||||||
|
|
||||||
scenario "Verifying organization links remembers parameters " do
|
scenario "Verifying organization links remembers parameters" do
|
||||||
allow(Organization).to receive(:default_per_page).and_return(2)
|
allow(Organization).to receive(:default_per_page).and_return(2)
|
||||||
4.times { create(:organization) }
|
4.times { create(:organization) }
|
||||||
|
|
||||||
|
|||||||
Reference in New Issue
Block a user