From 4e76f90afd37e6363dc0c7e3d4fc917e0821f933 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Javi=20Mart=C3=ADn?= Date: Fri, 21 Jun 2019 00:14:39 +0200 Subject: [PATCH] Simplify LEFT JOIN using ActiveRecord#left_joins This method is available since Rails 5.0. --- app/models/poll.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/models/poll.rb b/app/models/poll.rb index bd577670b..edef37f06 100644 --- a/app/models/poll.rb +++ b/app/models/poll.rb @@ -99,8 +99,8 @@ class Poll < ApplicationRecord def self.answerable_by(user) return none if user.nil? || user.unverified? - current.joins('LEFT JOIN "geozones_polls" ON "geozones_polls"."poll_id" = "polls"."id"') - .where("geozone_restricted = ? OR geozones_polls.geozone_id = ?", false, user.geozone_id) + current.left_joins(:geozones) + .where("geozone_restricted = ? OR geozones.id = ?", false, user.geozone_id) end def self.votable_by(user)