Refactor nested document tests to simplify contexts and remove duplication
This commit is contained in:
taitus
@@ -15,228 +15,187 @@ describe "Nested documentable" do
|
|||||||
let(:notice_text) { notice_text_for(factory, path) }
|
let(:notice_text) { notice_text_for(factory, path) }
|
||||||
|
|
||||||
context "New and edit path" do
|
context "New and edit path" do
|
||||||
describe "When allow attached documents setting is enabled" do
|
before do
|
||||||
before do
|
Setting["uploads.documents.max_amount"] = 1
|
||||||
Setting["uploads.documents.max_amount"] = 1
|
create(:administrator, user: user) if admin_section?(path)
|
||||||
create(:administrator, user: user) if admin_section?(path)
|
documentable.update!(author: user) if edit_path?(path)
|
||||||
documentable.update!(author: user) if edit_path?(path)
|
end
|
||||||
end
|
|
||||||
|
|
||||||
scenario "Shows or hides new document link depending on max documents limit" do
|
scenario "Shows or hides new document link depending on max documents limit" do
|
||||||
do_login_for(user, management: management_section?(path))
|
do_login_for(user, management: management_section?(path))
|
||||||
visit path
|
visit path
|
||||||
|
|
||||||
expect(page).to have_link "Add new document"
|
expect(page).to have_link "Add new document"
|
||||||
|
|
||||||
documentable_attach_new_file(file_fixture("empty.pdf"))
|
documentable_attach_new_file(file_fixture("empty.pdf"))
|
||||||
|
|
||||||
expect(page).not_to have_link "Add new document"
|
expect(page).not_to have_link "Add new document"
|
||||||
|
|
||||||
click_link "Remove document"
|
click_link "Remove document"
|
||||||
|
|
||||||
expect(page).to have_link "Add new document"
|
expect(page).to have_link "Add new document"
|
||||||
end
|
end
|
||||||
|
|
||||||
scenario "Shows or hides max documents warning depending on max documents limit" do
|
scenario "Shows or hides max documents warning depending on max documents limit" do
|
||||||
do_login_for(user, management: management_section?(path))
|
do_login_for(user, management: management_section?(path))
|
||||||
visit path
|
visit path
|
||||||
|
|
||||||
expect(page).not_to have_css ".max-documents-notice"
|
expect(page).not_to have_css ".max-documents-notice"
|
||||||
expect(page).not_to have_content "Remove document"
|
expect(page).not_to have_content "Remove document"
|
||||||
|
|
||||||
documentable_attach_new_file(file_fixture("empty.pdf"))
|
documentable_attach_new_file(file_fixture("empty.pdf"))
|
||||||
|
|
||||||
expect(page).to have_css ".max-documents-notice"
|
expect(page).to have_css ".max-documents-notice"
|
||||||
|
|
||||||
click_link "Remove document"
|
click_link "Remove document"
|
||||||
|
|
||||||
expect(page).not_to have_css ".max-documents-notice"
|
expect(page).not_to have_css ".max-documents-notice"
|
||||||
end
|
end
|
||||||
|
|
||||||
scenario "Should update file name and title after choosing a file with no title defined" do
|
scenario "Should update file name and title after choosing a file with no title defined" do
|
||||||
do_login_for(user, management: management_section?(path))
|
do_login_for(user, management: management_section?(path))
|
||||||
visit path
|
visit path
|
||||||
|
|
||||||
documentable_attach_new_file(file_fixture("empty.pdf"))
|
documentable_attach_new_file(file_fixture("empty.pdf"))
|
||||||
|
|
||||||
expect(page).to have_css ".file-name", text: "empty.pdf"
|
expect(page).to have_css ".file-name", text: "empty.pdf"
|
||||||
expect(page).to have_field("Title", with: "empty.pdf")
|
expect(page).to have_field("Title", with: "empty.pdf")
|
||||||
end
|
end
|
||||||
|
|
||||||
scenario "Should not change existing titles except when removing the document" do
|
scenario "Should not change existing titles except when removing the document" do
|
||||||
do_login_for(user, management: management_section?(path))
|
do_login_for(user, management: management_section?(path))
|
||||||
visit path
|
visit path
|
||||||
|
|
||||||
click_link "Add new document"
|
click_link "Add new document"
|
||||||
|
|
||||||
expect(page).not_to have_link "Add new document"
|
expect(page).not_to have_link "Add new document"
|
||||||
|
|
||||||
within "#nested-documents" do
|
|
||||||
fill_in "Title", with: "My Title"
|
|
||||||
attach_file "Choose document", file_fixture("empty.pdf")
|
|
||||||
|
|
||||||
expect(page).to have_css ".loading-bar.complete"
|
|
||||||
expect(page).to have_field "Title", with: "My Title"
|
|
||||||
|
|
||||||
click_link "Remove document"
|
|
||||||
|
|
||||||
expect(page).not_to have_css ".document-fields"
|
|
||||||
expect(page).not_to have_field "Title"
|
|
||||||
end
|
|
||||||
|
|
||||||
click_link "Add new document"
|
|
||||||
|
|
||||||
within "#nested-documents" do
|
|
||||||
expect(page).to have_field "Title", with: ""
|
|
||||||
expect(page).not_to have_field "Title", with: "My Title"
|
|
||||||
end
|
|
||||||
end
|
|
||||||
|
|
||||||
scenario "Should update document cached_attachment field after valid file upload" do
|
|
||||||
do_login_for(user, management: management_section?(path))
|
|
||||||
visit path
|
|
||||||
|
|
||||||
click_link "Add new document"
|
|
||||||
|
|
||||||
cached_attachment_field = find("input[name$='[cached_attachment]']", visible: :hidden)
|
|
||||||
expect(cached_attachment_field.value).to be_empty
|
|
||||||
|
|
||||||
|
within "#nested-documents" do
|
||||||
|
fill_in "Title", with: "My Title"
|
||||||
attach_file "Choose document", file_fixture("empty.pdf")
|
attach_file "Choose document", file_fixture("empty.pdf")
|
||||||
|
|
||||||
expect(page).to have_css(".loading-bar.complete")
|
expect(page).to have_css ".loading-bar.complete"
|
||||||
expect(cached_attachment_field.value).not_to be_empty
|
expect(page).to have_field "Title", with: "My Title"
|
||||||
|
|
||||||
|
click_link "Remove document"
|
||||||
|
|
||||||
|
expect(page).not_to have_css ".document-fields"
|
||||||
|
expect(page).not_to have_field "Title"
|
||||||
end
|
end
|
||||||
|
|
||||||
scenario "Should not update document cached_attachment field after invalid file upload" do
|
click_link "Add new document"
|
||||||
do_login_for(user, management: management_section?(path))
|
|
||||||
visit path
|
|
||||||
|
|
||||||
documentable_attach_new_file(file_fixture("logo_header.gif"), success: false)
|
within "#nested-documents" do
|
||||||
|
expect(page).to have_field "Title", with: ""
|
||||||
cached_attachment_field = find("input[name$='[cached_attachment]']", visible: :hidden)
|
expect(page).not_to have_field "Title", with: "My Title"
|
||||||
expect(cached_attachment_field.value).to be_empty
|
|
||||||
end
|
end
|
||||||
|
end
|
||||||
|
|
||||||
scenario "Should show document errors after documentable submit with empty document fields" do
|
scenario "Should update document cached_attachment field after valid file upload" do
|
||||||
do_login_for(user, management: management_section?(path))
|
do_login_for(user, management: management_section?(path))
|
||||||
visit path
|
visit path
|
||||||
|
|
||||||
|
click_link "Add new document"
|
||||||
|
|
||||||
|
cached_attachment_field = find("input[name$='[cached_attachment]']", visible: :hidden)
|
||||||
|
expect(cached_attachment_field.value).to be_empty
|
||||||
|
|
||||||
|
attach_file "Choose document", file_fixture("empty.pdf")
|
||||||
|
|
||||||
|
expect(page).to have_css(".loading-bar.complete")
|
||||||
|
expect(cached_attachment_field.value).not_to be_empty
|
||||||
|
end
|
||||||
|
|
||||||
|
scenario "Should not update document cached_attachment field after invalid file upload" do
|
||||||
|
do_login_for(user, management: management_section?(path))
|
||||||
|
visit path
|
||||||
|
|
||||||
|
documentable_attach_new_file(file_fixture("logo_header.gif"), success: false)
|
||||||
|
|
||||||
|
cached_attachment_field = find("input[name$='[cached_attachment]']", visible: :hidden)
|
||||||
|
expect(cached_attachment_field.value).to be_empty
|
||||||
|
end
|
||||||
|
|
||||||
|
scenario "Should show document errors after documentable submit with empty document fields" do
|
||||||
|
do_login_for(user, management: management_section?(path))
|
||||||
|
visit path
|
||||||
|
|
||||||
|
click_link "Add new document"
|
||||||
|
click_button submit_button_text
|
||||||
|
|
||||||
|
within "#nested-documents .document-fields" do
|
||||||
|
expect(page).to have_content("can't be blank", count: 2)
|
||||||
|
end
|
||||||
|
end
|
||||||
|
|
||||||
|
scenario "Should show successful notice when resource filled correctly without any nested documents" do
|
||||||
|
do_login_for(user, management: management_section?(path))
|
||||||
|
visit path
|
||||||
|
|
||||||
|
fill_in_required_fields(factory, path)
|
||||||
|
click_button submit_button_text
|
||||||
|
|
||||||
|
expect(page).to have_content notice_text
|
||||||
|
end
|
||||||
|
|
||||||
|
scenario "Should show successful notice when resource filled correctly and after valid file uploads" do
|
||||||
|
Setting["uploads.documents.max_amount"] = 3
|
||||||
|
do_login_for(user, management: management_section?(path))
|
||||||
|
visit path
|
||||||
|
|
||||||
|
fill_in_required_fields(factory, path)
|
||||||
|
|
||||||
|
%w[clippy empty logo].each do |filename|
|
||||||
click_link "Add new document"
|
click_link "Add new document"
|
||||||
click_button submit_button_text
|
|
||||||
|
|
||||||
within "#nested-documents .document-fields" do
|
attach_file "Choose document", file_fixture("#{filename}.pdf")
|
||||||
expect(page).to have_content("can't be blank", count: 2)
|
|
||||||
|
within all(".document-fields").last do
|
||||||
|
expect(page).to have_css ".loading-bar.complete"
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
|
||||||
scenario "Should show successful notice when resource filled correctly without any nested documents" do
|
expect(page).not_to have_link "Add new document"
|
||||||
do_login_for(user, management: management_section?(path))
|
|
||||||
visit path
|
|
||||||
|
|
||||||
fill_in_required_fields(factory, path)
|
click_button submit_button_text
|
||||||
click_button submit_button_text
|
|
||||||
|
|
||||||
expect(page).to have_content notice_text
|
expect(page).to have_content notice_text
|
||||||
end
|
if factory != :dashboard_action
|
||||||
|
within "#documents" do
|
||||||
scenario "Should show successful notice when resource filled correctly and after valid file uploads" do
|
expect(page).to have_content "Documents (3)"
|
||||||
Setting["uploads.documents.max_amount"] = 3
|
expect(page).to have_link href: /.pdf\Z/, count: 3
|
||||||
do_login_for(user, management: management_section?(path))
|
expect(page).to have_link text: "empty.pdf"
|
||||||
visit path
|
expect(page).to have_css "a[rel=nofollow]"
|
||||||
|
expect(page).to have_link text: "clippy.pdf"
|
||||||
fill_in_required_fields(factory, path)
|
expect(page).to have_css "a[rel=nofollow]"
|
||||||
|
expect(page).to have_link text: "logo.pdf"
|
||||||
%w[clippy empty logo].each do |filename|
|
expect(page).to have_css "a[rel=nofollow]"
|
||||||
click_link "Add new document"
|
expect(page).not_to have_css "a[target=_blank]"
|
||||||
|
|
||||||
attach_file "Choose document", file_fixture("#{filename}.pdf")
|
|
||||||
|
|
||||||
within all(".document-fields").last do
|
|
||||||
expect(page).to have_css ".loading-bar.complete"
|
|
||||||
end
|
|
||||||
end
|
|
||||||
|
|
||||||
expect(page).not_to have_link "Add new document"
|
|
||||||
|
|
||||||
click_button submit_button_text
|
|
||||||
|
|
||||||
expect(page).to have_content notice_text
|
|
||||||
if factory != :dashboard_action
|
|
||||||
within "#documents" do
|
|
||||||
expect(page).to have_content "Documents (3)"
|
|
||||||
expect(page).to have_link href: /.pdf\Z/, count: 3
|
|
||||||
expect(page).to have_link text: "empty.pdf"
|
|
||||||
expect(page).to have_css "a[rel=nofollow]"
|
|
||||||
expect(page).to have_link text: "clippy.pdf"
|
|
||||||
expect(page).to have_css "a[rel=nofollow]"
|
|
||||||
expect(page).to have_link text: "logo.pdf"
|
|
||||||
expect(page).to have_css "a[rel=nofollow]"
|
|
||||||
expect(page).not_to have_css "a[target=_blank]"
|
|
||||||
end
|
|
||||||
end
|
|
||||||
end
|
|
||||||
|
|
||||||
describe "Metadata" do
|
|
||||||
let(:factory) { (factories - [:dashboard_action]).sample }
|
|
||||||
|
|
||||||
scenario "download document without metadata" do
|
|
||||||
do_login_for(user, management: management_section?(path))
|
|
||||||
visit path
|
|
||||||
|
|
||||||
fill_in_required_fields(factory, path)
|
|
||||||
documentable_attach_new_file(file_fixture("logo_with_metadata.pdf"))
|
|
||||||
click_button submit_button_text
|
|
||||||
|
|
||||||
expect(page).to have_content notice_text
|
|
||||||
|
|
||||||
io = URI.parse(find_link(text: "PDF")[:href]).open
|
|
||||||
reader = PDF::Reader.new(io)
|
|
||||||
|
|
||||||
expect(reader.info[:Keywords]).not_to eq "Test Metadata"
|
|
||||||
expect(reader.info[:Author]).not_to eq "Test Developer"
|
|
||||||
expect(reader.info[:Title]).not_to eq "logo_with_metadata.pdf"
|
|
||||||
expect(reader.info[:Producer]).not_to eq "Test Producer"
|
|
||||||
expect(reader.info).to eq({})
|
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
|
||||||
describe "Only for edit path" do
|
describe "Metadata" do
|
||||||
let!(:proposal) { create(:proposal, author: user) }
|
let(:factory) { (factories - [:dashboard_action]).sample }
|
||||||
|
|
||||||
scenario "Should show persisted documents and remove nested_field" do
|
scenario "download document without metadata" do
|
||||||
Setting["uploads.documents.max_amount"] = 1
|
do_login_for(user, management: management_section?(path))
|
||||||
create(:document, documentable: proposal)
|
visit path
|
||||||
login_as user
|
|
||||||
visit edit_proposal_path(proposal)
|
|
||||||
|
|
||||||
expect(page).not_to have_link "Add new document"
|
fill_in_required_fields(factory, path)
|
||||||
expect(page).to have_css ".document-fields", count: 1
|
documentable_attach_new_file(file_fixture("logo_with_metadata.pdf"))
|
||||||
|
click_button submit_button_text
|
||||||
|
|
||||||
click_link "Remove document"
|
expect(page).to have_content notice_text
|
||||||
|
|
||||||
expect(page).to have_link "Add new document"
|
io = URI.parse(find_link(text: "PDF")[:href]).open
|
||||||
expect(page).not_to have_css ".document-fields"
|
reader = PDF::Reader.new(io)
|
||||||
end
|
|
||||||
|
|
||||||
scenario "Same attachment URL after editing the title" do
|
expect(reader.info[:Keywords]).not_to eq "Test Metadata"
|
||||||
login_as user
|
expect(reader.info[:Author]).not_to eq "Test Developer"
|
||||||
visit edit_proposal_path(proposal)
|
expect(reader.info[:Title]).not_to eq "logo_with_metadata.pdf"
|
||||||
|
expect(reader.info[:Producer]).not_to eq "Test Producer"
|
||||||
documentable_attach_new_file(file_fixture("empty.pdf"))
|
expect(reader.info).to eq({})
|
||||||
within_fieldset("Documents") { fill_in "Title", with: "Original" }
|
|
||||||
click_button "Save changes"
|
|
||||||
|
|
||||||
expect(page).to have_content "Proposal updated successfully"
|
|
||||||
|
|
||||||
original_url = find_link(text: "Original")[:href]
|
|
||||||
|
|
||||||
visit edit_proposal_path(proposal)
|
|
||||||
within_fieldset("Documents") { fill_in "Title", with: "Updated" }
|
|
||||||
click_button "Save changes"
|
|
||||||
|
|
||||||
expect(page).to have_content "Proposal updated successfully"
|
|
||||||
expect(find_link(text: "Updated")[:href]).to eq original_url
|
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
|
||||||
@@ -252,6 +211,45 @@ describe "Nested documentable" do
|
|||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
|
||||||
|
describe "Only for edit path" do
|
||||||
|
let!(:proposal) { create(:proposal, author: user) }
|
||||||
|
|
||||||
|
scenario "Should show persisted documents and remove nested_field" do
|
||||||
|
Setting["uploads.documents.max_amount"] = 1
|
||||||
|
create(:document, documentable: proposal)
|
||||||
|
login_as user
|
||||||
|
visit edit_proposal_path(proposal)
|
||||||
|
|
||||||
|
expect(page).not_to have_link "Add new document"
|
||||||
|
expect(page).to have_css ".document-fields", count: 1
|
||||||
|
|
||||||
|
click_link "Remove document"
|
||||||
|
|
||||||
|
expect(page).to have_link "Add new document"
|
||||||
|
expect(page).not_to have_css ".document-fields"
|
||||||
|
end
|
||||||
|
|
||||||
|
scenario "Same attachment URL after editing the title" do
|
||||||
|
login_as user
|
||||||
|
visit edit_proposal_path(proposal)
|
||||||
|
|
||||||
|
documentable_attach_new_file(file_fixture("empty.pdf"))
|
||||||
|
within_fieldset("Documents") { fill_in "Title", with: "Original" }
|
||||||
|
click_button "Save changes"
|
||||||
|
|
||||||
|
expect(page).to have_content "Proposal updated successfully"
|
||||||
|
|
||||||
|
original_url = find_link(text: "Original")[:href]
|
||||||
|
|
||||||
|
visit edit_proposal_path(proposal)
|
||||||
|
within_fieldset("Documents") { fill_in "Title", with: "Updated" }
|
||||||
|
click_button "Save changes"
|
||||||
|
|
||||||
|
expect(page).to have_content "Proposal updated successfully"
|
||||||
|
expect(find_link(text: "Updated")[:href]).to eq original_url
|
||||||
|
end
|
||||||
|
end
|
||||||
|
|
||||||
context "Show path" do
|
context "Show path" do
|
||||||
let(:factory) { (factories - [:dashboard_action]).sample }
|
let(:factory) { (factories - [:dashboard_action]).sample }
|
||||||
let(:path) { polymorphic_path(documentable) }
|
let(:path) { polymorphic_path(documentable) }
|
||||||
|
|||||||
Reference in New Issue
Block a user