consul/grecia
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Simplify test for heading names

Browse Source 
We were using `to_sentence` to check the order, while it's easier to
just check the exact contents of the array.

Furthermore, using `to_sentence` checked the order of the array, so it
was a potentially flaky spec since the method doesn't specify an order
and PostgreSQL doesn't guarantee the order of the records.
This commit is contained in:
Javi Martín
2019-09-26 18:46:03 +02:00
parent f69a0336a5
commit 44ffcfba2c
1 changed files with 4 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
spec/models/user_spec.rb
View File

@@ -11,29 +11,22 @@ describe User do
group = create(:budget_group, budget: budget)
new_york = create(:budget_heading, group: group, name: "New york")
san_franciso = create(:budget_heading, group: group, name: "San Franciso")
san_francisco = create(:budget_heading, group: group, name: "San Franciso")
wyoming = create(:budget_heading, group: group, name: "Wyoming")
another_heading = create(:budget_heading, group: group)
new_york_investment = create(:budget_investment, heading: new_york)
san_franciso_investment = create(:budget_investment, heading: san_franciso)
san_franciso_investment = create(:budget_investment, heading: san_francisco)
wyoming_investment = create(:budget_investment, heading: wyoming)
create(:vote, votable: wyoming_investment, voter: user1)
create(:vote, votable: san_franciso_investment, voter: user1)
create(:vote, votable: new_york_investment, voter: user1)
headings_names = "#{new_york.name}, #{san_franciso.name}, and #{wyoming.name}"
expect(user1.headings_voted_within_group(group)).to include(new_york)
expect(user1.headings_voted_within_group(group)).to include(san_franciso)
expect(user1.headings_voted_within_group(group)).to include(wyoming)
expect(user1.headings_voted_within_group(group)).to match_array [new_york, san_francisco, wyoming]
expect(user1.headings_voted_within_group(group)).not_to include(another_heading)
expect(user1.headings_voted_within_group(group).map(&:name).to_sentence).to eq(headings_names)
expect(user2.headings_voted_within_group(group)).not_to include(new_york)
expect(user2.headings_voted_within_group(group)).not_to include(san_franciso)
expect(user2.headings_voted_within_group(group)).not_to include(another_heading)
expect(user2.headings_voted_within_group(group)).to be_empty
end
it "returns headings with multiple translations only once" do