From 442dc2dc70852c2b2e74e27d04dc904366e22385 Mon Sep 17 00:00:00 2001
From: Alberto Garcia Cabeza <alberto@decabeza.es>
Date: Fri, 28 Apr 2017 13:05:05 +0200
Subject: [PATCH] improves banners helper

---
 app/helpers/banners_helper.rb      |  4 ++--
 app/views/debates/index.html.erb   |  2 +-
 app/views/proposals/index.html.erb |  2 +-
 app/views/shared/_banner.html.erb  | 10 +++++-----
 4 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/app/helpers/banners_helper.rb b/app/helpers/banners_helper.rb
index a1505a39e..b8b5864c9 100644
--- a/app/helpers/banners_helper.rb
+++ b/app/helpers/banners_helper.rb
@@ -1,7 +1,7 @@
 module BannersHelper
 
-  def has_banners
-    @banners.count > 0
+  def has_banners?
+    @banners.present? && @banners.count > 0
   end
 
 end
\ No newline at end of file
diff --git a/app/views/debates/index.html.erb b/app/views/debates/index.html.erb
index e38c52233..fd5e45059 100644
--- a/app/views/debates/index.html.erb
+++ b/app/views/debates/index.html.erb
@@ -27,7 +27,7 @@
         <% end %>
       </div>
 
-      <% if has_banners %>
+      <% if has_banners? %>
         <%= render "shared/banner" %>
       <% end %>
 
diff --git a/app/views/proposals/index.html.erb b/app/views/proposals/index.html.erb
index e04e563e2..e612567ab 100644
--- a/app/views/proposals/index.html.erb
+++ b/app/views/proposals/index.html.erb
@@ -29,7 +29,7 @@
         <% end %>
       </div>
 
-      <% if has_banners %>
+      <% if has_banners? %>
         <%= render "shared/banner" %>
       <% end %>
 
diff --git a/app/views/shared/_banner.html.erb b/app/views/shared/_banner.html.erb
index 6776e24a5..0ba7a2bd1 100644
--- a/app/views/shared/_banner.html.erb
+++ b/app/views/shared/_banner.html.erb
@@ -1,9 +1,9 @@
-<% banner = @banners.sample%>
+<% banner = @banners.sample %>
 <div class="<%= banner.style %>">
   <div class="<%= banner.image %>">
     <%= link_to banner.target_url do %>
-      <h2><%=banner.title%></h2>
-      <h3><%=banner.description%></h3>
-    <% end %> 
+      <h2><%=banner.title %></h2>
+      <h3><%=banner.description %></h3>
+    <% end %>
   </div>
-</div>
\ No newline at end of file
+</div>