consul/grecia
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Rename admin proposal notifications controller

Browse Source 
To be consistent with all the other controllers dealing with hidden
content, we use the word "hidden" in the controller class.
This commit is contained in:
Javi Martín
2020-06-15 12:02:17 +02:00
parent 539db4398a
commit 438a751599
9 changed files with 24 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
spec/system/admin/proposal_notifications_spec.rb
View File

@@ -8,7 +8,7 @@ describe "Admin proposal notifications" do
scenario "List shows all relevant info" do
proposal_notification = create(:proposal_notification, :hidden)
visit admin_proposal_notifications_path
visit admin_hidden_proposal_notifications_path
expect(page).to have_content(proposal_notification.title)
expect(page).to have_content(proposal_notification.body)
@@ -16,7 +16,7 @@ describe "Admin proposal notifications" do
scenario "Restore" do
proposal_notification = create(:proposal_notification, :hidden, created_at: Date.current - 5.days)
visit admin_proposal_notifications_path
visit admin_hidden_proposal_notifications_path
click_link "Restore"
@@ -29,7 +29,7 @@ describe "Admin proposal notifications" do
scenario "Confirm hide" do
proposal_notification = create(:proposal_notification, :hidden, created_at: Date.current - 5.days)
visit admin_proposal_notifications_path
visit admin_hidden_proposal_notifications_path
click_link "Confirm moderation"
@@ -41,22 +41,22 @@ describe "Admin proposal notifications" do
end
scenario "Current filter is properly highlighted" do
visit admin_proposal_notifications_path
visit admin_hidden_proposal_notifications_path
expect(page).not_to have_link("Pending")
expect(page).to have_link("All")
expect(page).to have_link("Confirmed")
visit admin_proposal_notifications_path(filter: "Pending")
visit admin_hidden_proposal_notifications_path(filter: "Pending")
expect(page).not_to have_link("Pending")
expect(page).to have_link("All")
expect(page).to have_link("Confirmed")
visit admin_proposal_notifications_path(filter: "all")
visit admin_hidden_proposal_notifications_path(filter: "all")
expect(page).to have_link("Pending")
expect(page).not_to have_link("All")
expect(page).to have_link("Confirmed")
visit admin_proposal_notifications_path(filter: "with_confirmed_hide")
visit admin_hidden_proposal_notifications_path(filter: "with_confirmed_hide")
expect(page).to have_link("All")
expect(page).to have_link("Pending")
expect(page).not_to have_link("Confirmed")
@@ -66,15 +66,15 @@ describe "Admin proposal notifications" do
create(:proposal_notification, :hidden, title: "Unconfirmed notification")
create(:proposal_notification, :hidden, :with_confirmed_hide, title: "Confirmed notification")
visit admin_proposal_notifications_path(filter: "pending")
visit admin_hidden_proposal_notifications_path(filter: "pending")
expect(page).to have_content("Unconfirmed notification")
expect(page).not_to have_content("Confirmed notification")
visit admin_proposal_notifications_path(filter: "all")
visit admin_hidden_proposal_notifications_path(filter: "all")
expect(page).to have_content("Unconfirmed notification")
expect(page).to have_content("Confirmed notification")
visit admin_proposal_notifications_path(filter: "with_confirmed_hide")
visit admin_hidden_proposal_notifications_path(filter: "with_confirmed_hide")
expect(page).not_to have_content("Unconfirmed notification")
expect(page).to have_content("Confirmed notification")
end
@@ -83,7 +83,7 @@ describe "Admin proposal notifications" do
allow(ProposalNotification).to receive(:default_per_page).and_return(2)
4.times { create(:proposal_notification, :hidden, :with_confirmed_hide) }
visit admin_proposal_notifications_path(filter: "with_confirmed_hide", page: 2)
visit admin_hidden_proposal_notifications_path(filter: "with_confirmed_hide", page: 2)
click_on("Restore", match: :first, exact: true)