From 431ebeda87d30710d75be2f2b17463125e0111f0 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Javi=20Mart=C3=ADn?= <javim@elretirao.net>
Date: Thu, 10 Oct 2024 23:38:57 +0200
Subject: [PATCH] Fix missing "for" attribute in document number label

Since this attribute was missing, the label wasn't correctly associated
with its field.
---
 app/views/verification/residence/new.html.erb |  2 +-
 spec/system/verification/residence_spec.rb    | 12 ++++++------
 2 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/app/views/verification/residence/new.html.erb b/app/views/verification/residence/new.html.erb
index a0d9b955e..c361d7d4c 100644
--- a/app/views/verification/residence/new.html.erb
+++ b/app/views/verification/residence/new.html.erb
@@ -38,7 +38,7 @@
           <div class="small-12 medium-5 column end">
 
           <div class="inline-block">
-            <%= f.label t("verification.residence.new.document_number") %>
+            <%= f.label :document_number, t("verification.residence.new.document_number") %>
           </div>
 
           <button type="button" class="inline-block" data-toggle="info-document-number">
diff --git a/spec/system/verification/residence_spec.rb b/spec/system/verification/residence_spec.rb
index 3603d4ba9..a44d6e3ae 100644
--- a/spec/system/verification/residence_spec.rb
+++ b/spec/system/verification/residence_spec.rb
@@ -10,7 +10,7 @@ describe "Residence" do
     visit account_path
     click_link "Verify my account"
 
-    fill_in "residence_document_number", with: "12345678Z"
+    fill_in "Document number", with: "12345678Z"
     select "DNI", from: "residence_document_type"
     select_date "31-December-1980", from: "residence_date_of_birth"
     fill_in "residence_postal_code", with: "28013"
@@ -28,7 +28,7 @@ describe "Residence" do
     visit account_path
     click_link "Verify my account"
 
-    fill_in "residence_document_number", with: "12345678Z"
+    fill_in "Document number", with: "12345678Z"
     select "DNI", from: "residence_document_type"
     select_date "31-December-1980", from: "residence_date_of_birth"
     fill_in "residence_postal_code", with: "28013"
@@ -63,7 +63,7 @@ describe "Residence" do
     visit account_path
     click_link "Verify my account"
 
-    fill_in "residence_document_number", with: "12345678Z"
+    fill_in "Document number", with: "12345678Z"
     select "DNI", from: "residence_document_type"
     select_date "31-December-1980", from: "residence_date_of_birth"
     fill_in "residence_postal_code", with: "28013"
@@ -98,7 +98,7 @@ describe "Residence" do
     visit account_path
     click_link "Verify my account"
 
-    fill_in "residence_document_number", with: "12345678Z"
+    fill_in "Document number", with: "12345678Z"
     select "DNI", from: "residence_document_type"
     select "1997", from: "residence_date_of_birth_1i"
     select "January", from: "residence_date_of_birth_2i"
@@ -118,7 +118,7 @@ describe "Residence" do
     visit account_path
     click_link "Verify my account"
 
-    fill_in "residence_document_number", with: "12345678Z"
+    fill_in "Document number", with: "12345678Z"
     select "DNI", from: "residence_document_type"
     select "1997", from: "residence_date_of_birth_1i"
     select "January", from: "residence_date_of_birth_2i"
@@ -139,7 +139,7 @@ describe "Residence" do
     click_link "Verify my account"
 
     5.times do
-      fill_in "residence_document_number", with: "12345678Z"
+      fill_in "Document number", with: "12345678Z"
       select "DNI", from: "residence_document_type"
       select "1997", from: "residence_date_of_birth_1i"
       select "January", from: "residence_date_of_birth_2i"