consul/grecia
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Avoid calls to let after starting the browser

Browse Source 
In some places, we were accidentally creating records after the browser
started because we weren't executing a `let` block before starting the
browser with a `visit`, but were executing the `let` block after that.
This commit is contained in:
Javi Martín
2025-03-27 18:08:17 +01:00
parent f5f96ba86e
commit 420ae41153
4 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
spec/system/admin/homepage/homepage_spec.rb
View File

@@ -12,7 +12,6 @@ describe "Homepage", :admin do
let!(:debates_feed) { create(:widget_feed, kind: "debates") } let!(:debates_feed) { create(:widget_feed, kind: "debates") }
let!(:processes_feed) { create(:widget_feed, kind: "processes") } let!(:processes_feed) { create(:widget_feed, kind: "processes") }
let(:user_recommendations) { Setting.find_by(key: "feature.user.recommendations") }
let(:user) { create(:user) } let(:user) { create(:user) }
context "Header" do context "Header" do
@@ -210,6 +209,7 @@ describe "Homepage", :admin do
scenario "Recomendations" do scenario "Recomendations" do
create(:proposal, tag_list: "Sport", followers: [user]) create(:proposal, tag_list: "Sport", followers: [user])
create(:proposal, tag_list: "Sport") create(:proposal, tag_list: "Sport")
user_recommendations = Setting.find_by(key: "feature.user.recommendations")
visit admin_homepage_path visit admin_homepage_path

2
spec/system/admin/translatable_spec.rb
View File

@@ -498,7 +498,7 @@ describe "Admin edit translatable records", :admin do
end end
context "Globalize javascript interface" do context "Globalize javascript interface" do
let(:translatable) { create(:i18n_content) } let!(:translatable) { create(:i18n_content) }
let(:content) { translatable } let(:content) { translatable }
let(:path) { admin_site_customization_information_texts_path } let(:path) { admin_site_customization_information_texts_path }

4
spec/system/budget_polls/voter_spec.rb
View File

@@ -6,7 +6,6 @@ describe "BudgetPolls", :with_frozen_time do
let(:poll) { create(:poll, budget: budget) } let(:poll) { create(:poll, budget: budget) }
let(:booth) { create(:poll_booth) } let(:booth) { create(:poll_booth) }
let(:officer) { create(:poll_officer) } let(:officer) { create(:poll_officer) }
let(:admin) { create(:administrator) }
let!(:user) { create(:user, :in_census) } let!(:user) { create(:user, :in_census) }
before do before do
@@ -16,6 +15,7 @@ describe "BudgetPolls", :with_frozen_time do
context "Offline" do context "Offline" do
scenario "A citizen can cast a paper vote" do scenario "A citizen can cast a paper vote" do
admin = create(:administrator).user
login_through_form_as_officer(officer) login_through_form_as_officer(officer)
visit new_officing_residence_path visit new_officing_residence_path
@@ -30,7 +30,7 @@ describe "BudgetPolls", :with_frozen_time do
end end
logout logout
login_as(admin.user) login_as(admin)
visit admin_poll_recounts_path(poll) visit admin_poll_recounts_path(poll)
within("#total_system") do within("#total_system") do

2
spec/system/budgets/budgets_spec.rb
View File

@@ -43,9 +43,11 @@ describe "Budgets" do
end end
scenario "Show finished budgets list" do scenario "Show finished budgets list" do
budget = create(:budget)
finished_budget_1 = create(:budget, :finished) finished_budget_1 = create(:budget, :finished)
finished_budget_2 = create(:budget, :finished) finished_budget_2 = create(:budget, :finished)
drafting_budget = create(:budget, :drafting) drafting_budget = create(:budget, :drafting)
visit budgets_path visit budgets_path
within("#finished_budgets") do within("#finished_budgets") do