Return the persisted line in add_investment

This method was returning a boolean value and caused a
`Naming/PredicateMethod` when upgrading rubocop.

So, instead, we're returning the created line when it was successfully
created, and `nil` when it wasn't.

Having said that, I'm not sure why we added the `.persisted?` back in
commit 3eb22ab7b since as far as I can tell we don't use the return
value for anything. The test added in commit da43e9e2e for this change
passes if we simply return `lines.create(investment: investment)`.

For now I'm leaving the `persisted?` check just in case, but removing it
might be fine.
This commit is contained in:
Javi Martín
2025-10-31 15:31:20 +01:00
parent 15f7632f3d
commit 413d0ed9be
2 changed files with 13 additions and 11 deletions

View File

@@ -10,7 +10,9 @@ class Budget
has_many :headings, -> { distinct }, through: :groups
def add_investment(investment)
lines.create(investment: investment).persisted?
line = lines.create(investment: investment)
line if line.persisted?
end
def total_amount_spent