consul/grecia
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Use keyword arguments in mappable specs

Browse Source 
We were getting a warning with Ruby 2.7 due to the change in the way
keyword arguments are handled in Ruby 3.0.

```
ruby/gems/2.7.0/gems/rspec-support-3.11.0/lib/rspec/support/with_keywords_when_needed.rb:18:
warning: Passing the keyword argument as the last hash parameter is
deprecated
```

As hinted by the warning, this code crashes with Ruby 3.0:

```
ArgumentError:
  unknown keyword: :budget_id
```

I'm not sure why this is the case, though, since we were already
explicitely passing a hash first before passing the keyword parameters.
I guess there are some cases in this whole keyword VS hash parameters
incompatibility that I haven't completely understood.
This commit is contained in:
Javi Martín
2021-09-19 17:25:36 +02:00
parent 5c2ca27df1
commit 3fe65bafd1
4 changed files with 4 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
spec/shared/system/mappable.rb
View File

@@ -1,4 +1,4 @@
shared_examples "mappable" do |mappable_factory_name, mappable_association_name, mappable_new_path, mappable_edit_path, mappable_show_path, mappable_path_arguments, management: false| shared_examples "mappable" do |mappable_factory_name, mappable_association_name, mappable_new_path, mappable_edit_path, mappable_show_path, mappable_path_arguments: {}, management: false|
let!(:user) { create(:user, :level_two) } let!(:user) { create(:user, :level_two) }
let!(:arguments) { {} } let!(:arguments) { {} }
let!(:mappable) { create(mappable_factory_name.to_s.to_sym) } let!(:mappable) { create(mappable_factory_name.to_s.to_sym) }

2
spec/system/budgets/investments_spec.rb
View File

@@ -1130,7 +1130,7 @@ describe "Budget Investments" do
"new_budget_investment_path", "new_budget_investment_path",
"", "",
"budget_investment_path", "budget_investment_path",
{ budget_id: "budget_id" } mappable_path_arguments: { budget_id: "budget_id" }
context "Destroy" do context "Destroy" do
scenario "Admin cannot destroy budget investments", :admin do scenario "Admin cannot destroy budget investments", :admin do

2
spec/system/management/budget_investments_spec.rb
View File

@@ -32,7 +32,7 @@ describe "Budget Investments" do
"new_management_budget_investment_path", "new_management_budget_investment_path",
"", "",
"management_budget_investment_path", "management_budget_investment_path",
{ budget_id: "budget_id" }, mappable_path_arguments: { budget_id: "budget_id" },
management: true management: true
context "Load" do context "Load" do

3
spec/system/proposals_spec.rb
View File

@@ -1296,8 +1296,7 @@ describe "Proposals" do
"proposal", "proposal",
"new_proposal_path", "new_proposal_path",
"edit_proposal_path", "edit_proposal_path",
"proposal_path", "proposal_path"
{}
scenario "Erased author" do scenario "Erased author" do
user = create(:user) user = create(:user)