consul/grecia
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Return no variants when document_number is blank

Browse Source 
Otherwise the variants returned for document_type="1" and
document_number="" will be

`["0", "00", "000", "0000", "00000", "000000", "0000000", "00000000"]`

which seems to be useless.
This commit is contained in:
Senén Rodero Rodríguez
2020-10-23 15:31:25 +02:00
committed by Javi Martín
parent 93e458d46e
commit 3ed4bdaff8
2 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lib/document_parser.rb
View File

@@ -1,5 +1,7 @@
module DocumentParser module DocumentParser
def get_document_number_variants(document_type, document_number) def get_document_number_variants(document_type, document_number)
return [] if document_number.blank?
# Delete all non-alphanumerics # Delete all non-alphanumerics
document_number = document_number.to_s.gsub(/[^0-9A-Za-z]/i, "") document_number = document_number.to_s.gsub(/[^0-9A-Za-z]/i, "")
variants = [] variants = []

4
spec/lib/document_parser_spec.rb
View File

@@ -3,6 +3,10 @@ include DocumentParser
describe DocumentParser do describe DocumentParser do
describe "#get_document_number_variants" do describe "#get_document_number_variants" do
it "returns no variants when document_number is not defined" do
expect(DocumentParser.get_document_number_variants("1", "")).to be_empty
end
it "trims and cleans up entry" do it "trims and cleans up entry" do
expect(DocumentParser.get_document_number_variants(2, " 1 2@ 34")).to eq(["1234"]) expect(DocumentParser.get_document_number_variants(2, " 1 2@ 34")).to eq(["1234"])
end end