From 3c73f354167c92d8030b2c285957569ec3aa9d12 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Alberto=20Miedes=20Garc=C3=A9s?= Date: Sat, 7 Jan 2017 22:20:28 +0100 Subject: [PATCH] Removed useless code --- config/api.yml | 1 - lib/graph_ql/association_resolver.rb | 8 +------- spec/lib/association_resolver_spec.rb | 7 ++----- 3 files changed, 3 insertions(+), 13 deletions(-) diff --git a/config/api.yml b/config/api.yml index bdf1b8175..452fa22f7 100644 --- a/config/api.yml +++ b/config/api.yml @@ -3,7 +3,6 @@ User: id: integer username: string Voter: - options: [disable_filtering] fields: gender: string age_range: string diff --git a/lib/graph_ql/association_resolver.rb b/lib/graph_ql/association_resolver.rb index 142b24313..22dd210f3 100644 --- a/lib/graph_ql/association_resolver.rb +++ b/lib/graph_ql/association_resolver.rb @@ -13,10 +13,6 @@ module GraphQL filter_forbidden_elements(requested_elements) end - def self.matching_exceptions - [:public_voter] - end - private def target_public_elements @@ -24,9 +20,7 @@ module GraphQL end def filter_forbidden_elements(requested_elements) - if AssociationResolver.matching_exceptions.include?(field_name) - requested_elements - elsif requested_elements.respond_to?(:each) + if requested_elements.respond_to?(:each) requested_elements.all & allowed_elements.all else allowed_elements.include?(requested_elements) ? requested_elements : nil diff --git a/spec/lib/association_resolver_spec.rb b/spec/lib/association_resolver_spec.rb index adb8a8b34..3e8bdf897 100644 --- a/spec/lib/association_resolver_spec.rb +++ b/spec/lib/association_resolver_spec.rb @@ -25,7 +25,7 @@ describe GraphQL::AssociationResolver do it 'resolves simple associations' do geozone = create(:geozone) proposal = create(:proposal, geozone: geozone) - + result = geozone_resolver.call(proposal, nil, nil) expect(result).to eq(geozone) @@ -54,9 +54,6 @@ describe GraphQL::AssociationResolver do expect(result).to be_empty end - - it 'permits all elements for exceptions' do - skip 'Current implementation is temporary' - end end + end