From 3b2fe1e184bd028f0fd610af1a6d52a0a146da5c Mon Sep 17 00:00:00 2001
From: Alberto Garcia Cabeza <alberto@decabeza.es>
Date: Mon, 5 Dec 2016 17:02:42 +0100
Subject: [PATCH] improves headings and outline structure

---
 app/assets/stylesheets/layout.scss             | 2 +-
 app/assets/stylesheets/participation.scss      | 8 ++++++--
 app/views/debates/show.html.erb                | 4 ++--
 app/views/kaminari/_paginator.html.erb         | 2 +-
 app/views/proposal_ballots/index.html.erb      | 2 +-
 app/views/proposals/_categories.html.erb       | 2 +-
 app/views/proposals/_geozones.html.erb         | 2 +-
 app/views/proposals/_popular.html.erb          | 2 +-
 app/views/proposals/_retired.html.erb          | 2 +-
 app/views/proposals/show.html.erb              | 4 ++--
 app/views/shared/_tag_cloud.html.erb           | 2 +-
 app/views/spending_proposals/_sidebar.html.erb | 2 +-
 12 files changed, 19 insertions(+), 15 deletions(-)

diff --git a/app/assets/stylesheets/layout.scss b/app/assets/stylesheets/layout.scss
index 6c6d739af..947349674 100644
--- a/app/assets/stylesheets/layout.scss
+++ b/app/assets/stylesheets/layout.scss
@@ -577,7 +577,7 @@ footer {
   }
 }
 
-h3.sidebar-title {
+h2.sidebar-title {
   border-top: 2px solid $brand;
   display: inline-block;
   font-size: rem-calc(16);
diff --git a/app/assets/stylesheets/participation.scss b/app/assets/stylesheets/participation.scss
index 6dbaac394..11d4c97a1 100644
--- a/app/assets/stylesheets/participation.scss
+++ b/app/assets/stylesheets/participation.scss
@@ -383,7 +383,7 @@
 
   aside {
 
-    h3 {
+    h2 {
       border-top: 2px solid $brand;
       display: inline-block;
       font-size: rem-calc(16);
@@ -844,11 +844,15 @@
   }
 
   p {
-    margin-bottom: 0;
 
     &.title {
       color: #FFD200;
     }
+
+    &.title-date {
+      font-size: rem-calc(24);
+      font-weight: bold;
+    }
   }
 
   .info {
diff --git a/app/views/debates/show.html.erb b/app/views/debates/show.html.erb
index dca39677e..7a528ffa7 100644
--- a/app/views/debates/show.html.erb
+++ b/app/views/debates/show.html.erb
@@ -44,12 +44,12 @@
 
       <aside class="small-12 medium-3 column">
         <div class="sidebar-divider"></div>
-        <h3><%= t("votes.supports") %></h3>
+        <h2><%= t("votes.supports") %></h2>
         <div id="<%= dom_id(@debate) %>_votes">
           <%= render 'debates/votes', debate: @debate %>
         </div>
         <div class="sidebar-divider"></div>
-        <h3><%= t("debates.show.share") %></h3>
+        <h2><%= t("debates.show.share") %></h2>
         <div class="social-share-full">
           <%= social_share_button_tag("#{@debate.title} #{setting['twitter_hashtag']}") %>
           <% if browser.device.mobile? %>
diff --git a/app/views/kaminari/_paginator.html.erb b/app/views/kaminari/_paginator.html.erb
index 3a1495a1c..ee5371ce5 100644
--- a/app/views/kaminari/_paginator.html.erb
+++ b/app/views/kaminari/_paginator.html.erb
@@ -1,7 +1,7 @@
 <%= paginator.render do -%>
   <div class="pagination-centered">
     <nav>
-      <h1 class="sr-only"><%= t("shared.outline.pagination") %></h1>
+      <h2 class="sr-only"><%= t("shared.outline.pagination") %></h2>
       <ul class="pagination text-center margin-top" aria-label="Pagination">
         <%= first_page_tag unless current_page.first? %>
         <%= prev_page_tag unless current_page.first? %>
diff --git a/app/views/proposal_ballots/index.html.erb b/app/views/proposal_ballots/index.html.erb
index 00a07fb9e..e05f8514a 100644
--- a/app/views/proposal_ballots/index.html.erb
+++ b/app/views/proposal_ballots/index.html.erb
@@ -11,7 +11,7 @@
 
     <div class="small-12 medium-4 column info" data-equalizer-watch>
       <p class="title"><strong><%= t("proposal_ballots.date_title") %></strong></p>
-      <h3><%= t("proposal_ballots.date") %></h3>
+      <p class="title-date"><%= t("proposal_ballots.date") %></p>
     </div>
   </div>
 </div>
diff --git a/app/views/proposals/_categories.html.erb b/app/views/proposals/_categories.html.erb
index 4d429b055..038934da4 100644
--- a/app/views/proposals/_categories.html.erb
+++ b/app/views/proposals/_categories.html.erb
@@ -1,5 +1,5 @@
 <div class="sidebar-divider"></div>
-<h3 class="sidebar-title"><%= t("shared.tags_cloud.categories") %></h3>
+<h2 class="sidebar-title"><%= t("shared.tags_cloud.categories") %></h2>
 <br>
 
 <div id="categories" class="categories">
diff --git a/app/views/proposals/_geozones.html.erb b/app/views/proposals/_geozones.html.erb
index ceec721ce..7e4dbcaa4 100644
--- a/app/views/proposals/_geozones.html.erb
+++ b/app/views/proposals/_geozones.html.erb
@@ -1,5 +1,5 @@
 <div class="sidebar-divider"></div>
-<h3 class="sidebar-title"><%= t("shared.tags_cloud.districts") %></h3>
+<h2 class="sidebar-title"><%= t("shared.tags_cloud.districts") %></h2>
 <br>
 <%= link_to map_proposals_path, id: 'map', title: t("shared.tags_cloud.districts_list") do %>
   <%= image_tag("map.jpg", alt: t("shared.tags_cloud.districts_list")) %>
diff --git a/app/views/proposals/_popular.html.erb b/app/views/proposals/_popular.html.erb
index 15ef8dccf..7f46ea802 100644
--- a/app/views/proposals/_popular.html.erb
+++ b/app/views/proposals/_popular.html.erb
@@ -1,5 +1,5 @@
 <div class="sidebar-divider"></div>
-<h3 class="sidebar-title"><%= t("proposals.index.top") %></h3>
+<h2 class="sidebar-title"><%= t("proposals.index.top") %></h2>
 
 <p>
   <%= link_to t("proposals.index.top_link_proposals"), summary_proposals_path, class: "small" %><br>
diff --git a/app/views/proposals/_retired.html.erb b/app/views/proposals/_retired.html.erb
index 280265d87..2167b14af 100644
--- a/app/views/proposals/_retired.html.erb
+++ b/app/views/proposals/_retired.html.erb
@@ -1,5 +1,5 @@
 <div class="sidebar-divider"></div>
-<h3 class="sidebar-title"><%= t("proposals.index.retired_proposals") %></h3>
+<h2 class="sidebar-title"><%= t("proposals.index.retired_proposals") %></h2>
 
 <% if params[:retired].blank? %>
   <p><%= link_to t("proposals.index.retired_proposals_link"), proposals_path(retired: 'all'), class: "small" %></p>
diff --git a/app/views/proposals/show.html.erb b/app/views/proposals/show.html.erb
index c010ed9db..920565d11 100644
--- a/app/views/proposals/show.html.erb
+++ b/app/views/proposals/show.html.erb
@@ -101,7 +101,7 @@
 
       <aside class="small-12 medium-3 column">
         <div class="sidebar-divider"></div>
-        <h3><%= t("votes.supports") %></h3>
+        <h2><%= t("votes.supports") %></h2>
         <div id="<%= dom_id(@proposal) %>_votes" class="supports text-center">
           <% if @proposal.successfull? %>
             <p>
@@ -119,7 +119,7 @@
           <% end %>
         </div>
         <div id="social-share" class="sidebar-divider"></div>
-        <h3><%= t("proposals.show.share") %></h3>
+        <h2><%= t("proposals.show.share") %></h2>
         <div class="social-share-full">
           <%= social_share_button_tag("#{@proposal.title} #{setting['twitter_hashtag']}") %>
           <% if browser.device.mobile? %>
diff --git a/app/views/shared/_tag_cloud.html.erb b/app/views/shared/_tag_cloud.html.erb
index 6b27de955..64a37172d 100644
--- a/app/views/shared/_tag_cloud.html.erb
+++ b/app/views/shared/_tag_cloud.html.erb
@@ -1,6 +1,6 @@
 <div id="tag-cloud" class="tag-cloud">
   <div class="sidebar-divider"></div>
-  <h3 class="sidebar-title"><%= t("shared.tags_cloud.tags") %></h3>
+  <h2 class="sidebar-title"><%= t("shared.tags_cloud.tags") %></h2>
   <br>
 
   <% @tag_cloud.tags.each do |tag| %>
diff --git a/app/views/spending_proposals/_sidebar.html.erb b/app/views/spending_proposals/_sidebar.html.erb
index 8fc8693e8..57d115d8c 100644
--- a/app/views/spending_proposals/_sidebar.html.erb
+++ b/app/views/spending_proposals/_sidebar.html.erb
@@ -1,5 +1,5 @@
 <div class="sidebar-divider"></div>
-<h3 class="sidebar-title"><%= t("spending_proposals.index.sidebar.geozones") %></h3>
+<h2 class="sidebar-title"><%= t("spending_proposals.index.sidebar.geozones") %></h2>
 <br>
 <div class="geozone">
   <%= link_to t('geozones.all'), spending_proposals_path(geozone: nil) %>