Merge pull request #1658 from consul/chore/add_coffeelint_config

Add CoffeeLint configuration file && Fixes

README.md

@@ -64,6 +64,12 @@ If you add SCSS code you can check it with:
 scss-lint
 ```
 
+If you work on Coffeescript code you can check it with [coffeelint](http://www.coffeelint.org/) (install with `npm install -g coffeelint`) :
+
+```
+coffeelint .
+```
+
 You can use the default admin user from the seeds file:
 
  **user:** admin@consul.dev

README_ES.md

@@ -65,6 +65,12 @@ Si añades código SCSS puedes revisarlo con:
 scss-lint
 ```
 
+Si trabajas en código coffeescript puedes revisarlo con [coffeelint](http://www.coffeelint.org/) (instalalo con `npm install -g coffeelint`) :
+
+```
+coffeelint .
+```
+
 Puedes usar el usuario administrador por defecto del fichero seeds:
 
  **user:** admin@consul.dev

app/assets/javascripts/advanced_search.js.coffee

@@ -4,7 +4,7 @@ App.AdvancedSearch =
     $('#js-advanced-search').data('advanced-search-terms')
 
   toggle_form: (event) ->
-    event.preventDefault();
+    event.preventDefault()
     $('#js-advanced-search').slideToggle()
 
   toggle_date_options: ->

app/assets/javascripts/allow_participation.js.coffee

@@ -3,10 +3,10 @@ App.AllowParticipation =
   initialize: ->
     $(document).on {
       'mouseenter focus': ->
-        $(this).find(".js-participation-not-allowed").show();
+        $(this).find(".js-participation-not-allowed").show()
-        $(this).find(".js-participation-allowed").hide();
+        $(this).find(".js-participation-allowed").hide()
       mouseleave: ->
-        $(this).find(".js-participation-not-allowed").hide();
+        $(this).find(".js-participation-not-allowed").hide()
-        $(this).find(".js-participation-allowed").show();
+        $(this).find(".js-participation-allowed").show()
     }, ".js-participation"
     false

app/assets/javascripts/fixed_bar.js.coffee

@@ -7,7 +7,7 @@ App.FixedBar =
       $(window).on 'scroll', ->
         if $(window).scrollTop() > fixedBarTopPosition
           $this.addClass('is-fixed')
-          $("#check-ballot").css({ 'display': "inline-block" });
+          $("#check-ballot").css({ 'display': "inline-block" })
         else
           $this.removeClass('is-fixed')
           $("#check-ballot").hide()

app/assets/javascripts/ie_alert.js.coffee

@@ -1,7 +1,7 @@
 App.IeAlert =
   set_cookie_and_hide: (event) ->
     event.preventDefault()
-    $.cookie('ie_alert_closed', 'true', { path: '/', expires: 365 });
+    $.cookie('ie_alert_closed', 'true', { path: '/', expires: 365 })
     $('.ie-callout').remove()
 
   initialize: ->

app/assets/javascripts/legislation_annotatable.js.coffee

@@ -84,7 +84,7 @@ App.LegislationAnnotatable =
         annotation_id: pid
         annotation_url: target.closest(".legislation-annotatable").data("legislation-annotatable-base-url")
 
-  isMobile: () ->
+  isMobile: ->
     return window.innerWidth <= 652
 
   viewerExtension: (viewer) ->

app/assets/javascripts/registration_form.js.coffee

@@ -21,5 +21,5 @@ App.RegistrationForm =
     if registrationForm.length > 0
       usernameInput.on "focusout", ->
         clearUsernameMessage()
-        username = usernameInput.val();
+        username = usernameInput.val()
         validateUsername(username) if username != ""

app/assets/javascripts/tags.js.coffee

@@ -12,7 +12,7 @@ App.Tags =
           current_tags = $tag_input.val().split(',').filter(Boolean)
 
           if $.inArray(name, current_tags) >= 0
-            current_tags.splice($.inArray(name, current_tags), 1);
+            current_tags.splice($.inArray(name, current_tags), 1)
           else
             current_tags.push name
 

app/assets/javascripts/users.js.coffee

@@ -1,5 +1,5 @@
 App.Users =
 
   initialize: ->
-    $('.initialjs-avatar').initial();
+    $('.initialjs-avatar').initial()
     false

app/assets/javascripts/votes.js.coffee

@@ -3,11 +3,11 @@ App.Votes =
   hoverize: (votes) ->
     $(document).on {
       'mouseenter focus': ->
-        $("div.participation-not-allowed", this).show();
+        $("div.participation-not-allowed", this).show()
-        $("div.participation-allowed", this).hide();
+        $("div.participation-allowed", this).hide()
       mouseleave: ->
-        $("div.participation-not-allowed", this).hide();
+        $("div.participation-not-allowed", this).hide()
-        $("div.participation-allowed", this).show();
+        $("div.participation-allowed", this).show()
     }, votes
 
   initialize: ->

coffeelint.json

@@ -0,0 +1,114 @@
+{
+  "coffeescript_error": {
+    "level": "error"
+  },
+  "arrow_spacing": {
+    "name": "arrow_spacing",
+    "level": "warn"
+  },
+  "no_tabs": {
+    "name": "no_tabs",
+    "level": "error"
+  },
+  "no_trailing_whitespace": {
+    "name": "no_trailing_whitespace",
+    "level": "warn",
+    "allowed_in_comments": false,
+    "allowed_in_empty_lines": true
+  },
+  "max_line_length": {
+    "name": "max_line_length",
+    "value": 140,
+    "level": "warn",
+    "limitComments": true
+  },
+  "line_endings": {
+    "name": "line_endings",
+    "level": "ignore",
+    "value": "unix"
+  },
+  "no_trailing_semicolons": {
+    "name": "no_trailing_semicolons",
+    "level": "error"
+  },
+  "indentation": {
+    "name": "indentation",
+    "value": 2,
+    "level": "error"
+  },
+  "camel_case_classes": {
+    "name": "camel_case_classes",
+    "level": "error"
+  },
+  "colon_assignment_spacing": {
+    "name": "colon_assignment_spacing",
+    "level": "warn",
+    "spacing": {
+      "left": 0,
+      "right": 1
+    }
+  },
+  "no_implicit_braces": {
+    "name": "no_implicit_braces",
+    "level": "ignore",
+    "strict": true
+  },
+  "no_plusplus": {
+    "name": "no_plusplus",
+    "level": "ignore"
+  },
+  "no_throwing_strings": {
+    "name": "no_throwing_strings",
+    "level": "error"
+  },
+  "no_backticks": {
+    "name": "no_backticks",
+    "level": "error"
+  },
+  "no_implicit_parens": {
+    "name": "no_implicit_parens",
+    "level": "ignore"
+  },
+  "no_empty_param_list": {
+    "name": "no_empty_param_list",
+    "level": "warn"
+  },
+  "no_stand_alone_at": {
+    "name": "no_stand_alone_at",
+    "level": "ignore"
+  },
+  "space_operators": {
+    "name": "space_operators",
+    "level": "warn"
+  },
+  "duplicate_key": {
+    "name": "duplicate_key",
+    "level": "error"
+  },
+  "empty_constructor_needs_parens": {
+    "name": "empty_constructor_needs_parens",
+    "level": "ignore"
+  },
+  "cyclomatic_complexity": {
+    "name": "cyclomatic_complexity",
+    "value": 10,
+    "level": "ignore"
+  },
+  "newlines_after_classes": {
+    "name": "newlines_after_classes",
+    "value": 3,
+    "level": "ignore"
+  },
+  "no_unnecessary_fat_arrows": {
+    "name": "no_unnecessary_fat_arrows",
+    "level": "warn"
+  },
+  "missing_fat_arrows": {
+    "name": "missing_fat_arrows",
+    "level": "ignore"
+  },
+  "non_empty_constructor_needs_parens": {
+    "name": "non_empty_constructor_needs_parens",
+    "level": "ignore"
+  }
+}