From 38b6cf36a2ca476cf008289da82de694c6f17b3e Mon Sep 17 00:00:00 2001
From: taitus <sebastia.roig@gmail.com>
Date: Wed, 7 Sep 2022 14:25:15 +0200
Subject: [PATCH] Remove unused add_question action from admin polls controller

Since commit adf18ee756  this action no longer makes sense.
---
 app/controllers/admin/poll/polls_controller.rb | 12 ------------
 app/models/abilities/administrator.rb          |  2 +-
 config/locales/en/admin.yml                    |  3 ---
 config/locales/es/admin.yml                    |  3 ---
 config/routes/admin.rb                         |  1 -
 5 files changed, 1 insertion(+), 20 deletions(-)

diff --git a/app/controllers/admin/poll/polls_controller.rb b/app/controllers/admin/poll/polls_controller.rb
index 5e9c84c90..71156ecf5 100644
--- a/app/controllers/admin/poll/polls_controller.rb
+++ b/app/controllers/admin/poll/polls_controller.rb
@@ -42,18 +42,6 @@ class Admin::Poll::PollsController < Admin::Poll::BaseController
     end
   end
 
-  def add_question
-    question = ::Poll::Question.find(params[:question_id])
-
-    if question.present?
-      @poll.questions << question
-      notice = t("admin.polls.flash.question_added")
-    else
-      notice = t("admin.polls.flash.error_on_question_added")
-    end
-    redirect_to admin_poll_path(@poll), notice: notice
-  end
-
   def booth_assignments
     @polls = Poll.current.created_by_admin
   end
diff --git a/app/models/abilities/administrator.rb b/app/models/abilities/administrator.rb
index 44201bdf4..9647f970f 100644
--- a/app/models/abilities/administrator.rb
+++ b/app/models/abilities/administrator.rb
@@ -83,7 +83,7 @@ module Abilities
 
       can [:index, :create, :update, :destroy], Geozone
 
-      can [:read, :create, :update, :destroy, :add_question, :booth_assignments], Poll
+      can [:read, :create, :update, :destroy, :booth_assignments], Poll
       can [:read, :create, :update, :destroy, :available], Poll::Booth
       can [:search, :create, :index, :destroy], ::Poll::Officer
       can [:create, :destroy, :manage], ::Poll::BoothAssignment
diff --git a/config/locales/en/admin.yml b/config/locales/en/admin.yml
index f615458c3..5e3e52896 100644
--- a/config/locales/en/admin.yml
+++ b/config/locales/en/admin.yml
@@ -1103,9 +1103,6 @@ en:
         table_title: "Title"
         edit_answers: Edit answers
         see_proposal: "(See proposal)"
-      flash:
-        question_added: "Question added to this poll"
-        error_on_question_added: "Question could not be assigned to this poll"
       destroy:
         alert: "This action will remove the poll and all its associated questions."
         success_notice: "Poll deleted successfully"
diff --git a/config/locales/es/admin.yml b/config/locales/es/admin.yml
index aa861ab09..d50c807da 100644
--- a/config/locales/es/admin.yml
+++ b/config/locales/es/admin.yml
@@ -1102,9 +1102,6 @@ es:
         table_title: "Título"
         edit_answers: Editar respuestas
         see_proposal: "(Ver propuesta)"
-      flash:
-        question_added: "Pregunta añadida a esta votación"
-        error_on_question_added: "No se pudo asignar la pregunta"
       destroy:
         alert: "Esta acción eliminará la votación y todas sus preguntas asociadas."
         success_notice: "Votación eliminada correctamente"
diff --git a/config/routes/admin.rb b/config/routes/admin.rb
index bae512e69..c3ee8f142 100644
--- a/config/routes/admin.rb
+++ b/config/routes/admin.rb
@@ -141,7 +141,6 @@ namespace :admin do
   scope module: :poll do
     resources :polls do
       get :booth_assignments, on: :collection
-      patch :add_question, on: :member
 
       resources :booth_assignments, only: [:index, :show, :create, :destroy] do
         get :search_booths, on: :collection