From 3762fd347e65f9b4eb4ca2bb177dfa2e144f8267 Mon Sep 17 00:00:00 2001 From: Bertocq Date: Sun, 7 Jan 2018 17:52:29 +0100 Subject: [PATCH] Enable RSpec/ScatteredSetup & fix issue Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/ScatteredSetup --- .rubocop.yml | 3 +++ spec/models/abilities/valuator_spec.rb | 6 ++++-- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/.rubocop.yml b/.rubocop.yml index a155bad11..4017c3c42 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -167,4 +167,7 @@ RSpec/ReturnFromStub: Enabled: true RSpec/ScatteredLet: + Enabled: true + +RSpec/ScatteredSetup: Enabled: true \ No newline at end of file diff --git a/spec/models/abilities/valuator_spec.rb b/spec/models/abilities/valuator_spec.rb index 1a6b7927d..cea3de6b3 100644 --- a/spec/models/abilities/valuator_spec.rb +++ b/spec/models/abilities/valuator_spec.rb @@ -10,8 +10,10 @@ describe Abilities::Valuator do let(:assigned_investment) { create(:budget_investment, budget: create(:budget, phase: 'valuating')) } let(:finished_assigned_investment) { create(:budget_investment, budget: create(:budget, phase: 'finished')) } - before { assigned_investment.valuators << valuator } - before { finished_assigned_investment.valuators << valuator } + before do + assigned_investment.valuators << valuator + finished_assigned_investment.valuators << valuator + end it { should be_able_to(:read, SpendingProposal) } it { should be_able_to(:update, SpendingProposal) }