Add and appy MultilineOperationIndentation rule

This way it's easier to see when lines are part of multiline
statements and when they belong to `if` statements.

.rubocop.yml

@@ -105,6 +105,9 @@ Layout/MultilineHashBraceLayout:
 Layout/MultilineHashKeyLineBreaks:
   Enabled: true
 
+Layout/MultilineOperationIndentation:
+  Enabled: true
+
 Layout/SpaceAfterColon:
   Enabled: true
 

app/components/admin/menu_component.rb

@@ -41,7 +41,7 @@ class Admin::MenuComponent < ApplicationComponent
     def polls?
       controller.class.module_parent == Admin::Poll::Questions::Answers ||
         %w[polls active_polls recounts results questions answers].include?(controller_name) &&
-        action_name != "booth_assignments"
+          action_name != "booth_assignments"
     end
 
     def booths?

app/helpers/admin_budget_investments_helper.rb

@@ -1,8 +1,8 @@
 module AdminBudgetInvestmentsHelper
   def advanced_menu_visibility
     if params[:advanced_filters].empty? &&
-      params["min_total_supports"].blank? &&
+       params["min_total_supports"].blank? &&
-      params["max_total_supports"].blank?
+       params["max_total_supports"].blank?
       "hide"
     else
       ""

app/helpers/globalize_helper.rb

@@ -35,7 +35,7 @@ module GlobalizeHelper
 
   def first_i18n_content_translation_locale
     if I18nContentTranslation.existing_languages.count == 0 ||
-        I18nContentTranslation.existing_languages.include?(I18n.locale)
+       I18nContentTranslation.existing_languages.include?(I18n.locale)
       I18n.locale
     else
       I18nContentTranslation.existing_languages.first

app/helpers/management_helper.rb

@@ -25,17 +25,17 @@ module ManagementHelper
 
   def menu_create_investments?
     (controller_name == "budget_investments" && action_name == "new") ||
-    (controller_name == "budgets" && action_name == "create_investments")
+      (controller_name == "budgets" && action_name == "create_investments")
   end
 
   def menu_support_investments?
     (controller_name == "budget_investments" && action_name == "index") ||
-    (controller_name == "budgets" && action_name == "support_investments")
+      (controller_name == "budgets" && action_name == "support_investments")
   end
 
   def menu_print_investments?
     (controller_name == "budget_investments" && action_name == "print") ||
-    (controller_name == "budgets" && action_name == "print_investments")
+      (controller_name == "budgets" && action_name == "print_investments")
   end
 
   def menu_user_invites?

app/helpers/milestones_helper.rb

@@ -10,7 +10,7 @@ module MilestonesHelper
             "aria-valuemin": "0",
             tabindex: "0" do
       tag.span(class: "progress-meter", style: "width: #{progress_bar.percentage}%;") +
-      tag.p(text, class: "progress-meter-text")
+        tag.p(text, class: "progress-meter-text")
     end
   end
 end

app/helpers/poll_recounts_helper.rb

@@ -2,8 +2,8 @@ module PollRecountsHelper
   def total_recounts_by_booth(booth_assignment)
     if booth_assignment.recounts.any?
       booth_assignment.recounts.sum(:total_amount) +
-      booth_assignment.recounts.sum(:white_amount) +
+        booth_assignment.recounts.sum(:white_amount) +
-      booth_assignment.recounts.sum(:null_amount)
+        booth_assignment.recounts.sum(:null_amount)
     end
   end
 end

app/helpers/proposals_dashboard_helper.rb

@@ -49,7 +49,7 @@ module ProposalsDashboardHelper
 
   def is_proposed_action_request?
     controller_name == "dashboard" && action_name == "new_request" &&
-    dashboard_action&.proposed_action?
+      dashboard_action&.proposed_action?
   end
 
   def is_request_active(id)

app/helpers/users_helper.rb

@@ -16,7 +16,7 @@ module UsersHelper
       deleted_commentable_text(comment)
     elsif commentable.hidden?
       tag.del(commentable.title) + " " +
-      tag.span("(#{deleted_commentable_text(comment)})", class: "small")
+        tag.span("(#{deleted_commentable_text(comment)})", class: "small")
     else
       link_to(commentable.title, comment)
     end

app/helpers/welcome_helper.rb

@@ -25,7 +25,7 @@ module WelcomeHelper
 
   def calculate_image_path(recommended, image_default)
     if recommended.respond_to?(:image) && recommended.image.present? &&
-        recommended.image.attachment.attached?
+       recommended.image.attachment.attached?
       recommended.image.variant(:medium)
     elsif image_default.present?
       image_default

app/models/local_census_records/import.rb

@@ -73,7 +73,7 @@ class LocalCensusRecords::Import
     def file_headers_definition
       headers = fetch_file_headers
       return if headers.all? { |header| ATTRIBUTES.include? header } &&
-        ATTRIBUTES.all? { |attr| headers.include? attr }
+                ATTRIBUTES.all? { |attr| headers.include? attr }
 
       errors.add :file, :headers, required_headers: ATTRIBUTES.join(", ")
     end

app/models/user.rb

@@ -396,7 +396,7 @@ class User < ApplicationRecord
     conditions = warden_conditions.dup
     login = conditions.delete(:login)
     where(conditions.to_hash).find_by(["lower(email) = ?", login.downcase]) ||
-    where(conditions.to_hash).find_by(["username = ?", login])
+      where(conditions.to_hash).find_by(["username = ?", login])
   end
 
   def self.find_by_manager_login(manager_login)

app/views/dashboard/_menu.html.erb

@@ -38,7 +38,7 @@
             <%= link_to proposal_dashboard_polls_path(proposal),
                         class: ("submenu-active" if polls_menu_active?) do %>
               <span data-tooltip title="<%= Setting["proposals.poll_short_title"] ||
-                                            t("dashboard.menu.polls") %>">
+                                              t("dashboard.menu.polls") %>">
                 <%= t("dashboard.menu.polls") %>
               </span>
             <% end %>
@@ -50,7 +50,7 @@
             <%= link_to new_proposal_dashboard_mailing_path(proposal),
                         class: ("submenu-active" if mailing_menu_active?) do %>
               <span data-tooltip title="<%= Setting["proposals.email_short_title"] ||
-                                            t("dashboard.menu.mailing") %>">
+                                              t("dashboard.menu.mailing") %>">
                 <%= t("dashboard.menu.mailing") %>
               </span>
             <% end %>
@@ -62,7 +62,7 @@
             <%= link_to new_proposal_dashboard_poster_path(proposal),
                         class: ("submenu-active" if poster_menu_active?) do %>
               <span data-tooltip title="<%= Setting["proposals.poster_short_title"] ||
-                                            t("dashboard.menu.poster") %>">
+                                              t("dashboard.menu.poster") %>">
                 <%= t("dashboard.menu.poster") %>
               </span>
             <% end %>

spec/components/shared/link_list_component_spec.rb

@@ -19,8 +19,8 @@ describe Shared::LinkListComponent do
     )
 
     expect(page).to be_rendered with: '<ul class="menu">' + "\n" +
-      '<li><a href="/">Home</a></li>' + "\n" +
+                                      '<li><a href="/">Home</a></li>' + "\n" +
-      '<li><a href="/info">Info</a></li>' + "\n</ul>\n"
+                                      '<li><a href="/info">Info</a></li>' + "\n</ul>\n"
   end
 
   it "accepts anchor tags" do
@@ -29,8 +29,8 @@ describe Shared::LinkListComponent do
     )
 
     expect(page).to be_rendered with: '<ul class="menu">' + "\n" +
-      '<li><a href="/">Home</a></li>' + "\n" +
+                                      '<li><a href="/">Home</a></li>' + "\n" +
-      '<li><a href="/info">Info</a></li>' + "\n</ul>\n"
+                                      '<li><a href="/info">Info</a></li>' + "\n</ul>\n"
   end
 
   it "accepts options for links" do