Manage proposal milestones

This commit is contained in:
Javi Martín
2018-11-15 15:11:36 +01:00
parent 8c45be7887
commit 2fcbee6261
10 changed files with 33 additions and 1 deletions

View File

@@ -0,0 +1,8 @@
class Admin::ProposalMilestonesController < Admin::MilestonesController
private
def milestoneable
Proposal.find(params[:proposal_id])
end
end

View File

@@ -7,3 +7,5 @@
<%= render "proposals/info", proposal: @proposal %>
</div>
<%= render "admin/milestones/milestones", milestoneable: @proposal %>

View File

@@ -21,4 +21,12 @@
</h3>
<% end %>
</li>
<li class="tabs-title">
<%= link_to "#tab-milestones" do %>
<h3>
<%= t("proposals.show.milestones_tab") %>
(<%= @proposal.milestones.count %>)
</h3>
<% end %>
</li>
</ul>

View File

@@ -140,4 +140,5 @@
</div>
<%= render "proposals/notifications" %>
<%= render "milestones/milestones", milestoneable: @proposal %>
</div>

View File

@@ -437,6 +437,7 @@ en:
flag: This proposal has been flagged as inappropriate by several users.
login_to_comment: You must %{signin} or %{signup} to leave a comment.
notifications_tab: Notifications
milestones_tab: Milestones
retired_warning: "The author considers this proposal should not receive more supports."
retired_warning_link_to_explanation: Read the explanation before voting for it.
retired: Proposal retired by the author

View File

@@ -437,6 +437,7 @@ es:
flag: Esta propuesta ha sido marcada como inapropiada por varios usuarios.
login_to_comment: Necesitas %{signin} o %{signup} para comentar.
notifications_tab: Notificaciones
milestones_tab: Seguimiento
retired_warning: "El autor de esta propuesta considera que ya no debe seguir recogiendo apoyos."
retired_warning_link_to_explanation: Revisa su explicación antes de apoyarla.
retired: Propuesta retirada por el autor

View File

@@ -434,6 +434,7 @@ val:
flag: Esta proposta ha sigut marcada com inapropiada per diversos usuaris.
login_to_comment: Necessites %{signin} o %{signup} per a comentar.
notifications_tab: Notificacions
milestones_tab: Seguiments
retired_warning: "L'autor d'esta proposta considera que ja no ha de seguir recollint avals."
retired_warning_link_to_explanation: Revisa la seua explicació abans d'avalar-la.
retired: Proposta retirada per l'autor

View File

@@ -29,7 +29,9 @@ namespace :admin do
end
end
resources :proposals, only: [:index, :show]
resources :proposals, only: [:index, :show] do
resources :milestones, controller: "proposal_milestones"
end
resources :hidden_proposals, only: :index do
member do

View File

@@ -5,6 +5,10 @@ feature "Admin proposals" do
login_as create(:administrator).user
end
it_behaves_like "admin_milestoneable",
:proposal,
"admin_proposal_path"
context "Index" do
scenario "Search" do
create(:proposal, title: "Make Pluto a planet again")

View File

@@ -3,6 +3,10 @@ require 'rails_helper'
feature 'Proposals' do
it_behaves_like "milestoneable",
:proposal,
"proposal_path"
scenario 'Disabled with a feature flag' do
Setting['feature.proposals'] = nil
expect{ visit proposals_path }.to raise_exception(FeatureFlags::FeatureDisabled)