Remove redundant feature settings enabled in tests
These settings are enabled by default. It could be argued explicitely enabling the features makes tests more consistent, because they'll work if we change the default setting. It could also be argued that it makes tests more expressive because it makes the reader realize certain things will only work if a setting is enabled. However, we were only doing so in a few tests. The truth is, thousands of our tests depend on certain features being enabled. So IMHO we should be consistent and either set them on every test, or not at all. I'm choosing the latter option for simplicity.
This commit is contained in:
@@ -25,7 +25,6 @@ describe "Home" do
|
||||
describe "Recommended" do
|
||||
|
||||
before do
|
||||
Setting["feature.user.recommendations"] = true
|
||||
user = create(:user)
|
||||
proposal = create(:proposal, tag_list: "Sport")
|
||||
create(:follow, followable: proposal, user: user)
|
||||
|
||||
Reference in New Issue
Block a user