From 2d4d057b48fb2892e12511c812cca28ca30babf9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Juanjo=20Baza=CC=81n?= Date: Wed, 20 Jan 2016 16:16:13 +0100 Subject: [PATCH] returns empty 404 instead of raising exception for the catch-all route --- app/controllers/pages_controller.rb | 2 +- spec/controllers/pages_controller_spec.rb | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/app/controllers/pages_controller.rb b/app/controllers/pages_controller.rb index 34cdb2e09..03f62925a 100644 --- a/app/controllers/pages_controller.rb +++ b/app/controllers/pages_controller.rb @@ -4,6 +4,6 @@ class PagesController < ApplicationController def show render action: params[:id] rescue ActionView::MissingTemplate - raise ActionController::RoutingError.new('Not Found') + head 404 end end diff --git a/spec/controllers/pages_controller_spec.rb b/spec/controllers/pages_controller_spec.rb index b696adb77..eed930a57 100644 --- a/spec/controllers/pages_controller_spec.rb +++ b/spec/controllers/pages_controller_spec.rb @@ -60,7 +60,8 @@ describe PagesController do describe 'Not found pages' do it 'should return a 404 message' do - expect { get :show, id: "nonExistentPage" }.to raise_error(ActionController::RoutingError) + get :show, id: "nonExistentPage" + expect(response).to be_missing end end