From 2bc60184656a33c1a60f5a46914da0077af5e9a5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Javi=20Mart=C3=ADn?= Date: Wed, 11 Aug 2021 17:53:34 +0200 Subject: [PATCH] Add and apply Style/HashConversion rubocop rule This rule was added in Rubocop 1.10.0. This style is IMHO clearer and possible since Ruby 2.1. --- .rubocop.yml | 3 +++ app/helpers/settings_helper.rb | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/.rubocop.yml b/.rubocop.yml index 31cdfe4d2..49ca9e144 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -469,6 +469,9 @@ Style/ClassVars: Style/CollectionMethods: Enabled: true +Style/HashConversion: + Enabled: true + Style/HashSyntax: Enabled: true diff --git a/app/helpers/settings_helper.rb b/app/helpers/settings_helper.rb index 7280f71f2..e82330676 100644 --- a/app/helpers/settings_helper.rb +++ b/app/helpers/settings_helper.rb @@ -13,7 +13,7 @@ module SettingsHelper end def setting - @all_settings ||= Hash[Setting.all.map { |s| [s.key, s.value.presence] }] + @all_settings ||= Setting.all.map { |s| [s.key, s.value.presence] }.to_h end def display_setting_name(setting_name)