consul/grecia
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Unify expectations on spec components folder

Browse Source 
In this PR (https://github.com/consul/consul/pull/4683) a new syntax was introduced
in the component specs to check that the component was not rendering.
It seems interesting to add this syntax to the rest of the cases and thus unify the way
we check that a component is not rendering.
This commit is contained in:
taitus
2021-11-03 11:56:36 +01:00
parent 21170d0f24
commit 2b35144540
15 changed files with 22 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
spec/components/admin/budgets/duration_component_spec.rb
View File

@@ -49,7 +49,7 @@ describe Admin::Budgets::DurationComponent do
render Admin::Budgets::DurationComponent.new(durable).duration
expect(page.text).to be_empty
expect(page.native.inner_html).to be_empty
end
it "is not defined when no start date is defined" do
@@ -57,7 +57,7 @@ describe Admin::Budgets::DurationComponent do
render Admin::Budgets::DurationComponent.new(durable).duration
expect(page.text).to be_empty
expect(page.native.inner_html).to be_empty
end
end

3
spec/components/admin/budgets_wizard/headings/group_switcher_component_spec.rb
View File

@@ -6,8 +6,7 @@ describe Admin::BudgetsWizard::Headings::GroupSwitcherComponent do
render_inline Admin::BudgetsWizard::Headings::GroupSwitcherComponent.new(group)
expect(page.text).to be_empty
expect(page).not_to have_css ".budget-group-switcher"
expect(page.native.inner_html).to be_empty
end
it "renders a link to switch group for budgets with two groups" do

3
spec/components/budgets/supports_info_component_spec.rb
View File

@@ -28,8 +28,7 @@ describe Budgets::SupportsInfoComponent do
render_inline component
expect(page).not_to have_selector ".supports-info"
expect(page.text).to be_empty
expect(page.native.inner_html).to be_empty
end
describe "#total_supports" do

3
spec/components/layout/locale_switcher_component_spec.rb
View File

@@ -13,8 +13,7 @@ describe Layout::LocaleSwitcherComponent do
it "doesn't render anything" do
render_inline component
expect(page.text).to be_empty
expect(page).not_to have_css ".locale"
expect(page.native.inner_html).to be_empty
end
end

2
spec/components/layout/social_component_spec.rb
View File

@@ -33,7 +33,7 @@ describe Layout::SocialComponent do
render_inline Layout::SocialComponent.new
expect(page).not_to have_css "ul"
expect(page.native.inner_html).to be_empty
end
end
end

2
spec/components/layout/top_links_component_spec.rb
View File

@@ -13,7 +13,7 @@ describe Layout::TopLinksComponent do
it "does not render when no content block is defined" do
render_inline Layout::TopLinksComponent.new
expect(page).not_to have_css "ul"
expect(page.native.inner_html).to be_empty
end
end
end

2
spec/components/sdg/goals/help_page_component_spec.rb
View File

@@ -13,7 +13,7 @@ describe SDG::Goals::HelpPageComponent do
render_inline component
expect(page).not_to have_css ".sdg-help-content"
expect(page.native.inner_html).to be_empty
end
it "renders content when the feature is enabled" do

2
spec/components/sdg/goals/plain_tag_list_component_spec.rb
View File

@@ -14,7 +14,7 @@ describe SDG::Goals::PlainTagListComponent do
render_inline component
expect(page).not_to have_css "li"
expect(page.native.inner_html).to be_empty
end
it "does not render when the SDG process feature is disabled" do

4
spec/components/sdg/goals/tag_list_component_spec.rb
View File

@@ -14,7 +14,7 @@ describe SDG::Goals::TagListComponent do
render_inline component
expect(page).not_to have_css "li"
expect(page.native.inner_html).to be_empty
end
it "does not render when the SDG process feature is disabled" do
@@ -22,7 +22,7 @@ describe SDG::Goals::TagListComponent do
render_inline component
expect(page).not_to have_css "li"
expect(page.native.inner_html).to be_empty
end
it "renders a list of goals" do

4
spec/components/sdg/goals/targets_component_spec.rb
View File

@@ -13,9 +13,7 @@ describe SDG::Goals::TargetsComponent do
render_inline component
expect(page).not_to have_css ".targets"
expect(page).not_to have_css "#target_tabs"
expect(page).not_to have_css ".tabs-content"
expect(page.native.inner_html).to be_empty
end
it "renders tabs panel" do

4
spec/components/sdg/related_list_selector_component_spec.rb
View File

@@ -15,7 +15,7 @@ describe SDG::RelatedListSelectorComponent do
render_inline component
expect(page).not_to have_css ".sdg-related-list-selector"
expect(page.native.inner_html).to be_empty
end
it "does not render when the SDG process feature is disabled" do
@@ -23,7 +23,7 @@ describe SDG::RelatedListSelectorComponent do
render_inline component
expect(page).not_to have_css ".sdg-related-list-selector"
expect(page.native.inner_html).to be_empty
end
it "renders related_sdg_list field" do

4
spec/components/sdg/targets/plain_tag_list_component_spec.rb
View File

@@ -18,7 +18,7 @@ describe SDG::Targets::PlainTagListComponent do
render_inline component
expect(page).not_to have_css "li"
expect(page.native.inner_html).to be_empty
end
it "does not render when the SDG process feature is disabled" do
@@ -26,7 +26,7 @@ describe SDG::Targets::PlainTagListComponent do
render_inline component
expect(page).not_to have_css "li"
expect(page.native.inner_html).to be_empty
end
it "renders a list of targets" do

4
spec/components/sdg/targets/tag_list_component_spec.rb
View File

@@ -18,7 +18,7 @@ describe SDG::Targets::TagListComponent do
render_inline component
expect(page).not_to have_css "li"
expect(page.native.inner_html).to be_empty
end
it "does not render when the SDG process feature is disabled" do
@@ -26,7 +26,7 @@ describe SDG::Targets::TagListComponent do
render_inline component
expect(page).not_to have_css "li"
expect(page.native.inner_html).to be_empty
end
it "renders a list of targets" do

4
spec/components/shared/banner_component_spec.rb
View File

@@ -82,13 +82,13 @@ describe Shared::BannerComponent do
render_inline Shared::BannerComponent.new("debates")
expect(page).not_to have_css ".banner"
expect(page.native.inner_html).to be_empty
end
end
it "does not render anything given nil" do
render_inline Shared::BannerComponent.new(nil)
expect(page).not_to have_css ".banner"
expect(page.native.inner_html).to be_empty
end
end

4
spec/components/shared/link_list_component_spec.rb
View File

@@ -4,13 +4,13 @@ describe Shared::LinkListComponent do
it "renders nothing with an empty list" do
render_inline Shared::LinkListComponent.new
expect(page).not_to have_css "ul"
expect(page.native.inner_html).to be_empty
end
it "returns nothing with a list of nil elements" do
render_inline Shared::LinkListComponent.new(nil, nil)
expect(page).not_to have_css "ul"
expect(page.native.inner_html).to be_empty
end
it "generates a list of links" do