From 28aaa584e9f56b437bf05702647e9b4fac1e2c97 Mon Sep 17 00:00:00 2001 From: taitus Date: Wed, 2 Aug 2017 12:32:42 +0200 Subject: [PATCH] Fix proposal refactor. --- app/models/proposal.rb | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/app/models/proposal.rb b/app/models/proposal.rb index ed629f1a1..c9a0ea985 100644 --- a/app/models/proposal.rb +++ b/app/models/proposal.rb @@ -59,21 +59,21 @@ class Proposal < ActiveRecord::Base def self.recommendations(user) proposals_list = where("author_id != ?", user.id) - proposals_list_with_tagged = proposals_with_tagged(user, proposals_list) + proposals_list_with_tagged = self.proposals_with_tagged(user, proposals_list) if proposals_list_with_tagged.any? - proposals_list = proposals_not_followed_by_user(user, proposals_list_with_tagged) + proposals_list = self.proposals_not_followed_by_user(user, proposals_list_with_tagged) end proposals_list end - def proposals_with_tagged(user, proposals_list) + def self.proposals_with_tagged(user, proposals_list) proposals_list.joins(:tags).where('taggings.taggable_type = ?', self.name) .where('tags.name IN (?)', user.interests) end - def proposals_not_followed_by_user(user, proposals_list_with_tagged) + def self.proposals_not_followed_by_user(user, proposals_list_with_tagged) followed_proposals_ids = Proposal.followed_by_user(user).pluck(:id) proposals_list_with_tagged.where("proposals.id NOT IN (?)", followed_proposals_ids) end