consul/grecia
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Improve performance swapping keys.each for each_key, plus line lenght comply

Browse Source
This commit is contained in:
Bertocq
2018-01-19 23:44:08 +01:00
parent 7f6c1f4e97
commit 28008d64e2
1 changed files with 9 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
spec/controllers/installation_controller_spec.rb
View File

@@ -15,12 +15,18 @@ describe InstallationController, type: :request do
before do before do
@current_feature_settings = seeds_feature_settings.pluck(:key, :value).to_h @current_feature_settings = seeds_feature_settings.pluck(:key, :value).to_h
seeds_feature_settings.destroy_all seeds_feature_settings.destroy_all
test_feature_settings.each { |feature_name, feature_value| Setting["feature.#{feature_name}"] = feature_value } test_feature_settings.each do |feature_name, feature_value|
Setting["feature.#{feature_name}"] = feature_value
end
end end
after do after do
test_feature_settings.keys.each { |feature_name| Setting.find_by(key: "feature.#{feature_name}").destroy } test_feature_settings.each_key do |feature_name|
@current_feature_settings.each { |feature_name, feature_value| Setting[feature_name] = feature_value } Setting.find_by(key: "feature.#{feature_name}").destroy
end
@current_feature_settings.each do |feature_name, feature_value|
Setting[feature_name] = feature_value
end
end end
specify "with query string inside query params" do specify "with query string inside query params" do