consul/grecia
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Add unfinished trait to investment factories

Browse Source 
Now the code is symmetrical since we also use `finished`.
This commit is contained in:
Javi Martín
2019-09-21 14:59:26 +02:00
parent 53fa527118
commit 24e8f07dae
4 changed files with 7 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
spec/factories/budgets.rb
View File

@@ -114,6 +114,10 @@ FactoryBot.define do
valuation_finished { true } valuation_finished { true }
end end
trait :unfinished do
valuation_finished { false }
end
trait :selected do trait :selected do
selected { true } selected { true }
feasibility { "feasible" } feasibility { "feasible" }

2
spec/features/admin/budget_investments_spec.rb
View File

@@ -346,7 +346,7 @@ describe "Admin budget investments" do
valuator = create(:valuator, user: user) valuator = create(:valuator, user: user)
create(:budget_investment, create(:budget_investment,
:with_administrator, :with_administrator,
valuation_finished: false, :unfinished,
title: "Investment without valuation", title: "Investment without valuation",
budget: budget, budget: budget,
valuators: [valuator]) valuators: [valuator])

2
spec/features/budgets/investments_spec.rb
View File

@@ -1263,7 +1263,7 @@ describe "Budget Investments" do
investment = create(:budget_investment, investment = create(:budget_investment,
:unfeasible, :unfeasible,
valuation_finished: false, :unfinished,
budget: budget, budget: budget,
group: group, group: group,
heading: heading, heading: heading,

5
spec/models/budget/investment_spec.rb
View File

@@ -1228,10 +1228,7 @@ describe Budget::Investment do
let(:params) { { advanced_filters: ["under_valuation"], budget_id: budget.id } } let(:params) { { advanced_filters: ["under_valuation"], budget_id: budget.id } }
it "returns only investment under valuation" do it "returns only investment under valuation" do
valuator1 = create(:valuator) valuator1 = create(:valuator)
investment1 = create(:budget_investment, investment1 = create(:budget_investment, :with_administrator, :unfinished, budget: budget)
:with_administrator,
valuation_finished: false,
budget: budget)
investment1.valuators << valuator1 investment1.valuators << valuator1
create(:budget_investment, :with_administrator, budget: budget) create(:budget_investment, :with_administrator, budget: budget)
create(:budget_investment, budget: budget) create(:budget_investment, budget: budget)