Fix crash when adding invalid documents to answers

We were rendering the `new` action, but that action doesn't exist.
Before commit ec861ca8e, we were rendering the `edit` action of an
answer, which was confusing as well.

Note that, when adding an invalid document, `@answer.documents` contains
that invalid document (which is not present in the database). Since
we're rendering the index, this new document would appear in the list of
the documents that can be deleted; to avoid that, we're kind of
"reloading" the answer object in the component by finding the record in
the database. We aren't using `@answer.reload` because doing so would
remove the validation errors.

app/components/admin/poll/questions/answers/documents/index_component.html.erb

@@ -26,14 +26,14 @@
     </div>
   <% end %>
 
-  <% if answer.documents.present? %>
+  <% if documents.present? %>
     <table>
       <tr>
         <th scope="col"><%= t("admin.questions.show.answers.document_title") %></th>
         <th scope="col"><%= t("admin.questions.show.answers.document_actions") %></th>
       </tr>
 
-      <% answer.documents.each do |document| %>
+      <% documents.each do |document| %>
         <tr>
           <td>
             <%= link_to document.title, document.attachment %>

app/components/admin/poll/questions/answers/documents/index_component.rb

@@ -5,4 +5,10 @@ class Admin::Poll::Questions::Answers::Documents::IndexComponent < ApplicationCo
   def initialize(answer)
     @answer = answer
   end
+
+  private
+
+    def documents
+      @documents ||= @answer.class.find(@answer.id).documents
+    end
 end

app/controllers/admin/poll/questions/answers/documents_controller.rb

@@ -14,7 +14,7 @@ class Admin::Poll::Questions::Answers::DocumentsController < Admin::Poll::BaseCo
       redirect_to admin_answer_documents_path(@answer),
         notice: t("admin.documents.create.success_notice")
     else
-      render :new
+      render :index
     end
   end
 

spec/system/admin/poll/questions/answers/documents/documents_spec.rb

@@ -24,16 +24,31 @@ describe "Documents", :admin do
     end
   end
 
-  scenario "Create document for answer" do
+  describe "Create document for answer" do
-    answer = create(:poll_question_answer, poll: future_poll)
+    scenario "with valid data" do
+      answer = create(:poll_question_answer, poll: future_poll)
 
-    visit admin_answer_documents_path(answer)
+      visit admin_answer_documents_path(answer)
 
-    documentable_attach_new_file(Rails.root.join("spec/fixtures/files/clippy.pdf"))
+      documentable_attach_new_file(Rails.root.join("spec/fixtures/files/clippy.pdf"))
-    click_button "Save"
+      click_button "Save"
 
-    expect(page).to have_content "Document uploaded successfully"
+      expect(page).to have_content "Document uploaded successfully"
-    expect(page).to have_link "clippy.pdf"
+      expect(page).to have_link "clippy.pdf"
+    end
+
+    scenario "with invalid data" do
+      answer = create(:poll_question_answer, poll: future_poll)
+
+      visit admin_answer_documents_path(answer)
+
+      documentable_attach_new_file(Rails.root.join("spec/fixtures/files/clippy.pdf"))
+      fill_in "Title", with: ""
+      click_button "Save"
+
+      expect(page).to have_content "1 error prevented this Answer from being saved"
+      expect(page).to have_content "Documents list"
+    end
   end
 
   scenario "Remove document from answer" do