From 2253155a51b512ee261792b63e4d5b018477a183 Mon Sep 17 00:00:00 2001 From: Bertocq Date: Sun, 7 Jan 2018 00:50:50 +0100 Subject: [PATCH] Enables RSpec/EmptyLineAfterSubject & fixes all issues Read more about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/EmptyLineAfterSubject --- .rubocop.yml | 3 +++ spec/models/abilities/administrator_spec.rb | 1 + spec/models/abilities/common_spec.rb | 1 + spec/models/abilities/moderator_spec.rb | 1 + spec/models/abilities/organization_spec.rb | 1 + spec/models/abilities/valuator_spec.rb | 1 + spec/models/verification/management/email_spec.rb | 1 + 7 files changed, 9 insertions(+) diff --git a/.rubocop.yml b/.rubocop.yml index 115d3be5a..9e3b96105 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -65,4 +65,7 @@ RSpec/DescribedClass: Enabled: true RSpec/EmptyExampleGroup: + Enabled: true + +RSpec/EmptyLineAfterSubject: Enabled: true \ No newline at end of file diff --git a/spec/models/abilities/administrator_spec.rb b/spec/models/abilities/administrator_spec.rb index 51e94040f..b6841edb5 100644 --- a/spec/models/abilities/administrator_spec.rb +++ b/spec/models/abilities/administrator_spec.rb @@ -3,6 +3,7 @@ require 'cancan/matchers' describe Abilities::Administrator do subject(:ability) { Ability.new(user) } + let(:user) { administrator.user } let(:administrator) { create(:administrator) } diff --git a/spec/models/abilities/common_spec.rb b/spec/models/abilities/common_spec.rb index 4b4ac5047..78ed985b2 100644 --- a/spec/models/abilities/common_spec.rb +++ b/spec/models/abilities/common_spec.rb @@ -3,6 +3,7 @@ require 'cancan/matchers' describe Abilities::Common do subject(:ability) { Ability.new(user) } + let(:geozone) { create(:geozone) } let(:user) { create(:user, geozone: geozone) } diff --git a/spec/models/abilities/moderator_spec.rb b/spec/models/abilities/moderator_spec.rb index d67804f3f..a2b374a85 100644 --- a/spec/models/abilities/moderator_spec.rb +++ b/spec/models/abilities/moderator_spec.rb @@ -3,6 +3,7 @@ require 'cancan/matchers' describe Abilities::Moderator do subject(:ability) { Ability.new(user) } + let(:user) { moderator.user } let(:moderator) { create(:moderator) } diff --git a/spec/models/abilities/organization_spec.rb b/spec/models/abilities/organization_spec.rb index 3c1bc4feb..a897a03df 100644 --- a/spec/models/abilities/organization_spec.rb +++ b/spec/models/abilities/organization_spec.rb @@ -3,6 +3,7 @@ require 'cancan/matchers' describe 'Abilities::Organization' do subject(:ability) { Ability.new(user) } + let(:user) { organization.user } let(:organization) { create(:organization) } let(:debate) { create(:debate) } diff --git a/spec/models/abilities/valuator_spec.rb b/spec/models/abilities/valuator_spec.rb index 214e68f6e..8bd2da1d0 100644 --- a/spec/models/abilities/valuator_spec.rb +++ b/spec/models/abilities/valuator_spec.rb @@ -3,6 +3,7 @@ require 'cancan/matchers' describe Abilities::Valuator do subject(:ability) { Ability.new(user) } + let(:user) { valuator.user } let(:valuator) { create(:valuator) } let(:non_assigned_investment) { create(:budget_investment) } diff --git a/spec/models/verification/management/email_spec.rb b/spec/models/verification/management/email_spec.rb index 652c094ba..e71376322 100644 --- a/spec/models/verification/management/email_spec.rb +++ b/spec/models/verification/management/email_spec.rb @@ -4,6 +4,7 @@ describe Verification::Management::Email do describe "#user" do subject { described_class.new(document_type: "1", document_number: "1234", email: "inexisting@gmail.com") } + it "returns nil/false when the user does not exist" do expect(subject.user).to be_nil expect(subject.user?).to_not be