consul/grecia
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove unnecessary "reload" method calls in tests

Browse Source 
Using "reload" might cause issues if the process running the browser has
already been started, and it isn't necessary in these cases.
This commit is contained in:
Javi Martín
2021-04-10 14:41:18 +02:00
parent 907c0fc679
commit 21c715bb2a
3 changed files with 10 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
spec/system/admin/budget_investments_spec.rb
View File

@@ -1587,7 +1587,7 @@ describe "Admin budget investments", :admin do
investment1.update!(administrator: admin) investment1.update!(administrator: admin)
investment2.update!(administrator: admin) investment2.update!(administrator: admin)
login_as(valuator.user.reload) login_as(valuator.user)
visit root_path visit root_path
click_link "Menu" click_link "Menu"
click_link "Valuation" click_link "Valuation"

2
spec/system/admin/translatable_spec.rb
View File

@@ -323,7 +323,7 @@ describe "Admin edit translatable records", :admin do
expect(page).not_to have_css "#error_explanation" expect(page).not_to have_css "#error_explanation"
visit edit_admin_legislation_process_path(translatable.reload) visit edit_admin_legislation_process_path(translatable)
expect_to_have_language_selected "Français" expect_to_have_language_selected "Français"
expect_not_to_have_language "English" expect_not_to_have_language "English"

17
spec/system/proposal_notifications_spec.rb
View File

@@ -237,8 +237,7 @@ describe "Proposal Notifications" do
user2 = create(:user, followables: [proposal]) user2 = create(:user, followables: [proposal])
user3 = create(:user) user3 = create(:user)
login_as author.reload login_as author
visit root_path
visit new_proposal_notification_path(proposal_id: proposal.id) visit new_proposal_notification_path(proposal_id: proposal.id)
@@ -250,7 +249,7 @@ describe "Proposal Notifications" do
expect(page).to have_content "Your message has been sent correctly." expect(page).to have_content "Your message has been sent correctly."
logout logout
login_as user1.reload login_as user1
visit root_path visit root_path
click_link "You have a new notification" click_link "You have a new notification"
@@ -262,7 +261,7 @@ describe "Proposal Notifications" do
expect(page).to have_current_path(proposal_path(proposal)) expect(page).to have_current_path(proposal_path(proposal))
logout logout
login_as user2.reload login_as user2
visit root_path visit root_path
click_link "You have a new notification" click_link "You have a new notification"
@@ -274,7 +273,7 @@ describe "Proposal Notifications" do
expect(page).to have_current_path(proposal_path(proposal)) expect(page).to have_current_path(proposal_path(proposal))
logout logout
login_as user3.reload login_as user3
visit root_path visit root_path
click_link "You don't have new notifications" click_link "You don't have new notifications"
@@ -332,7 +331,7 @@ describe "Proposal Notifications" do
proposal = create(:proposal, author: author) proposal = create(:proposal, author: author)
user = create(:user, followables: [proposal]) user = create(:user, followables: [proposal])
login_as author.reload login_as author
3.times do 3.times do
visit new_proposal_notification_path(proposal_id: proposal.id) visit new_proposal_notification_path(proposal_id: proposal.id)
@@ -345,7 +344,7 @@ describe "Proposal Notifications" do
end end
logout logout
login_as user.reload login_as user
visit root_path visit root_path
click_link "You have 3 new notifications" click_link "You have 3 new notifications"
@@ -373,7 +372,7 @@ describe "Proposal Notifications" do
author = create(:user) author = create(:user)
proposal = create(:proposal, author: author) proposal = create(:proposal, author: author)
login_as author.reload login_as author
visit new_proposal_notification_path(proposal_id: proposal.id) visit new_proposal_notification_path(proposal_id: proposal.id)
fill_in "Title", with: "Thank you for supporting my proposal" fill_in "Title", with: "Thank you for supporting my proposal"
@@ -395,7 +394,7 @@ describe "Proposal Notifications" do
author = create(:user) author = create(:user)
proposal = create(:proposal, author: author) proposal = create(:proposal, author: author)
login_as author.reload login_as author
visit new_proposal_notification_path(proposal_id: proposal.id) visit new_proposal_notification_path(proposal_id: proposal.id)
fill_in "Title", with: "Thank you for supporting my proposal" fill_in "Title", with: "Thank you for supporting my proposal"