Cleanup Lint/AssignmentInCondition rubocop issues on code and remove it from ruboco_todo list

2017-06-16 00:17:19 +02:00
parent 87e73e772c
commit 21c6d1c4dd
7 changed files with 28 additions and 24 deletions
--- a/app/models/site_customization/image.rb
+++ b/app/models/site_customization/image.rb
@@ -21,9 +21,8 @@ class SiteCustomization::Image < ActiveRecord::Base
  def self.image_path_for(filename)
    image_name = filename.split(".").first

-    if i = find_by(name: image_name)
-      i.image.exists? ? i.image.url : nil
-    end
+    imageable = find_by(name: image_name)
+    imageable.present? && imageable.image.exists? ? imageable.image.url : nil
  end

  def required_width