Bump rubocop from 1.76.1 to 1.81.1

This release includes some updates in the Style/RedundantParentheses and
Naming/PredicateMethod rules. We're changing the code accordingly.

Bumps [rubocop](https://github.com/rubocop/rubocop) from 1.76.1 to 1.81.1.
- [Release notes](https://github.com/rubocop/rubocop/releases)
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rubocop/rubocop/compare/v1.76.1...v1.81.1)

---
updated-dependencies:
- dependency-name: rubocop
  dependency-version: 1.81.1
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Gemfile

@@ -103,7 +103,7 @@ group :development do
   gem "pronto-eslint", "~> 0.11.1", require: false
   gem "pronto-rubocop", "~> 0.11.6", require: false
   gem "pronto-stylelint", "~> 0.11.1", require: false
-  gem "rubocop", "~> 1.76.1", require: false
+  gem "rubocop", "~> 1.81.7", require: false
   gem "rubocop-capybara", "~> 2.22.1", require: false
   gem "rubocop-factory_bot", "~> 2.27.1", require: false
   gem "rubocop-performance", "~> 1.26.1", require: false

Gemfile.lock

@@ -625,7 +625,7 @@ GEM
       rspec-mocks (~> 3.13)
       rspec-support (~> 3.13)
     rspec-support (3.13.2)
-    rubocop (1.76.1)
+    rubocop (1.81.7)
       json (~> 2.3)
       language_server-protocol (~> 3.17.0.2)
       lint_roller (~> 1.1.0)
@@ -633,7 +633,7 @@ GEM
       parser (>= 3.3.0.2)
       rainbow (>= 2.2.2, < 4.0)
       regexp_parser (>= 2.9.3, < 3.0)
-      rubocop-ast (>= 1.45.0, < 2.0)
+      rubocop-ast (>= 1.47.1, < 2.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 2.4.0, < 4.0)
     rubocop-ast (1.47.1)
@@ -889,7 +889,7 @@ DEPENDENCIES
   rinku (~> 2.0.6)
   ros-apartment (~> 3.2.0)
   rspec-rails (~> 7.1.1)
-  rubocop (~> 1.76.1)
+  rubocop (~> 1.81.7)
   rubocop-capybara (~> 2.22.1)
   rubocop-factory_bot (~> 2.27.1)
   rubocop-performance (~> 1.26.1)

app/controllers/concerns/search.rb

@@ -42,7 +42,7 @@ module Search
   end
 
   def search_finish_date
-    (params[:advanced_search][:date_max].to_date rescue Date.current) || Date.current
+    params[:advanced_search][:date_max].to_date rescue Date.current || Date.current
   end
 
   def search_date_range

app/helpers/budgets_helper.rb

@@ -16,7 +16,7 @@ module BudgetsHelper
     Budget::Ballot.find_by(user: current_user, budget: @budget)
   end
 
-  def unfeasible_or_unselected_filter
+  def unfeasible_or_unselected_filter?
     ["unselected", "unfeasible"].include?(@current_filter)
   end
 

app/helpers/proposals_dashboard_helper.rb

@@ -89,9 +89,8 @@ module ProposalsDashboardHelper
   end
 
   def new_resources_since_last_login?(resources, new_actions_since_last_login)
-    if resources.present?
+    resources.present? &&
       resources.ids.any? { |id| new_actions_since_last_login.include?(id) }
-    end
   end
 
   def active_resources_for(proposal)

app/views/budgets/investments/index.html.erb

@@ -45,7 +45,7 @@
 
     <%= render Shared::AdvancedSearchComponent.new %>
 
-    <% if unfeasible_or_unselected_filter %>
+    <% if unfeasible_or_unselected_filter? %>
       <ul class="no-bullet submenu">
         <li class="inline-block">
           <%= link_to current_path_with_query_params(order: "random", page: 1),