Use where.not instead of where(NOT IN)

This way we simplify the code a bit and reduce our usage of raw SQL.
This commit is contained in:
Javi Martín
2020-05-19 16:03:32 +02:00
parent f427c757ba
commit 1b34c061bb
4 changed files with 6 additions and 7 deletions

View File

@@ -96,7 +96,7 @@ class UsersController < ApplicationController
disabled_commentables << "Debate" unless Setting["process.debates"]
disabled_commentables << "Budget::Investment" unless Setting["process.budgets"]
if disabled_commentables.present?
all_user_comments.where("commentable_type NOT IN (?)", disabled_commentables)
all_user_comments.where.not(commentable_type: disabled_commentables)
else
all_user_comments
end