consul/grecia
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove unneeded optgroup in locale switcher

Browse Source 
The `<optgroup>` doesn't make much sense if all options are inside one
group. And the information provided was redundant: when using a select
field having "Language" as a label, it's obvious that the options are
the available languages.

Now that, since now the `<select>` field is smaller, we need to add an
extra padding so the icon doesn't overlap the text.
This commit is contained in:
Javi Martín
2021-06-25 22:23:06 +02:00
parent 93c521bd29
commit 1a477eb511
4 changed files with 8 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
app/views/shared/_locale_switcher.html.erb
View File

@@ -5,14 +5,12 @@
<%= t("layouts.header.locale") %>
</label>
<select class="js-location-changer locale-switcher inline-block" name="locale-switcher" id="locale-switcher">
<optgroup label="<%= t("layouts.header.available_locales") %>">
<% I18n.available_locales.map do |loc| %>
<option <%= "selected" if loc == I18n.locale %>
value="<%= current_path_with_query_params(locale: loc) %>">
<%= name_for_locale(loc) %>
</option>
<% end %>
</optgroup>
<% I18n.available_locales.map do |loc| %>
<option <%= "selected" if loc == I18n.locale %>
value="<%= current_path_with_query_params(locale: loc) %>">
<%= name_for_locale(loc) %>
</option>
<% end %>
</select>
</form>
</div>