From 1747d85c90e677e8001a1d1fefc121f19b2aca14 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Javi=20Mart=C3=ADn?= Date: Sat, 27 Mar 2021 13:10:35 +0100 Subject: [PATCH] Explicitly disable JS with other file formats JavaScripts drivers emulate browser behavior and browsers might download these files instead of opening them. --- spec/system/admin/budget_investments_spec.rb | 2 +- spec/system/admin/emails/emails_download_spec.rb | 2 +- spec/system/legislation/summary_spec.rb | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/spec/system/admin/budget_investments_spec.rb b/spec/system/admin/budget_investments_spec.rb index ab100e0af..de5004fa9 100644 --- a/spec/system/admin/budget_investments_spec.rb +++ b/spec/system/admin/budget_investments_spec.rb @@ -1692,7 +1692,7 @@ describe "Admin budget investments", :admin do end end - context "Selecting csv" do + context "Selecting csv", :no_js do scenario "Downloading CSV file" do admin = create(:administrator, user: create(:user, username: "Admin")) valuator = create(:valuator, user: create(:user, username: "Valuator")) diff --git a/spec/system/admin/emails/emails_download_spec.rb b/spec/system/admin/emails/emails_download_spec.rb index b842e4276..e7e4183e9 100644 --- a/spec/system/admin/emails/emails_download_spec.rb +++ b/spec/system/admin/emails/emails_download_spec.rb @@ -22,7 +22,7 @@ describe "Admin download user emails" do admin_without_email.update_column(:email, nil) end - scenario "returns the selected users segment csv file" do + scenario "returns the selected users segment csv file", :no_js do visit admin_emails_download_index_path within("#admin_download_emails") do diff --git a/spec/system/legislation/summary_spec.rb b/spec/system/legislation/summary_spec.rb index 880c7ee4e..94f3d1ab6 100644 --- a/spec/system/legislation/summary_spec.rb +++ b/spec/system/legislation/summary_spec.rb @@ -165,7 +165,7 @@ describe "Legislation" do expect(page).to have_link "Comment 3" end - scenario "excel download" do + scenario "excel download", :no_js do visit summary_legislation_process_path(process) click_link "Download summary"