Make it easier to customize allowed parameters
When customizing CONSUL, one of the most common actions is adding a new
field to a form.
This requires modifying the permitted/allowed parameters. However, in
most cases, the method returning these parameters returned an instance
of `ActionController::Parameters`, so adding more parameters to it
wasn't easy.
So customizing the code required copying the method returning those
parameters and adding the new ones. For example:
```
def something_params
params.require(:something).permit(
:one_consul_attribute,
:another_consul_attribute,
:my_custom_attribute
)
end
```
This meant that, if the `something_params` method changed in CONSUL, the
customization of this method had to be updated as well.
So we're extracting the logic returning the parameters to a method which
returns an array. Now this code can be customized without copying the
original method:
```
alias_method :consul_allowed_params, :allowed_params
def allowed_params
consul_allowed_params + [:my_custom_attribute]
end
```
This commit is contained in:
@@ -44,7 +44,10 @@ class Admin::ValuatorsController < Admin::BaseController
|
||||
|
||||
def valuator_params
|
||||
params[:valuator][:description] = nil if params[:valuator][:description].blank?
|
||||
params.require(:valuator).permit(:user_id, :description, :valuator_group_id,
|
||||
:can_comment, :can_edit_dossier)
|
||||
params.require(:valuator).permit(allowed_params)
|
||||
end
|
||||
|
||||
def allowed_params
|
||||
[:user_id, :description, :valuator_group_id, :can_comment, :can_edit_dossier]
|
||||
end
|
||||
end
|
||||
|
||||
Reference in New Issue
Block a user