consul/grecia
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

updates specs to new keyword styles

Browse Source
This commit is contained in:
Juanjo Bazán
2017-06-16 13:14:41 +02:00
committed by Julian Herrero
parent b62eff841c
commit 0f34cae2ad
4 changed files with 64 additions and 57 deletions
Download Patch File Download Diff File Expand all files Collapse all files

88
spec/controllers/legislation/annotations_controller_spec.rb
View File

@@ -13,13 +13,14 @@ describe Legislation::AnnotationsController do
it "creates an ahoy event" do
sign_in @user
post :create, process_id: @process.id,
draft_version_id: @draft_version.id,
legislation_annotation: {
"quote" => "ipsum",
"ranges" => [{"start" => "/p[1]", "startOffset" => 6, "end" => "/p[1]", "endOffset" => 11}],
"text": "una anotacion"
}
post :create, params: {
process_id: @process.id,
draft_version_id: @draft_version.id,
legislation_annotation: {
"quote"=>"ipsum",
"ranges"=>[{"start"=>"/p[1]", "startOffset"=>6, "end"=>"/p[1]", "endOffset"=>11}],
"text": "una anotacion"
}}
expect(Ahoy::Event.where(name: :legislation_annotation_created).count).to eq 1
expect(Ahoy::Event.last.properties["legislation_annotation_id"]).to eq Legislation::Annotation.last.id
end
@@ -27,13 +28,14 @@ describe Legislation::AnnotationsController do
it "does not create an annotation if the draft version is a final version" do
sign_in @user
post :create, process_id: @process.id,
post :create, params: {
process_id: @process.id,
draft_version_id: @final_version.id,
legislation_annotation: {
"quote" => "ipsum",
"ranges" => [{"start" => "/p[1]", "startOffset" => 6, "end" => "/p[1]", "endOffset" => 11}],
"text": "una anotacion"
}
}}
expect(response).to have_http_status(:not_found)
end
@@ -42,13 +44,15 @@ describe Legislation::AnnotationsController do
sign_in @user
expect do
xhr :post, :create, process_id: @process.id,
draft_version_id: @draft_version.id,
legislation_annotation: {
"quote" => "ipsum",
"ranges" => [{"start" => "/p[1]", "startOffset" => 6, "end" => "/p[1]", "endOffset" => 11}],
"text": "una anotacion"
}
post :create, params: {
process_id: @process.id,
draft_version_id: @draft_version.id,
legislation_annotation: {
"quote"=>"ipsum",
"ranges"=>[{"start"=>"/p[1]", "startOffset"=>6, "end"=>"/p[1]", "endOffset"=>11}],
"text": "una anotacion"
}},
xhr: true
end.to change { @draft_version.annotations.count }.by(1)
end
@@ -57,27 +61,31 @@ describe Legislation::AnnotationsController do
@process.update_attribute(:allegations_end_date, Date.current - 1.day)
expect do
xhr :post, :create, process_id: @process.id,
draft_version_id: @draft_version.id,
legislation_annotation: {
"quote" => "ipsum",
"ranges" => [{"start" => "/p[1]", "startOffset" => 6, "end" => "/p[1]", "endOffset" => 11}],
"text": "una anotacion"
}
end.not_to change { @draft_version.annotations.count }
post :create, params: {
process_id: @process.id,
draft_version_id: @draft_version.id,
legislation_annotation: {
"quote"=>"ipsum",
"ranges"=>[{"start"=>"/p[1]", "startOffset"=>6, "end"=>"/p[1]", "endOffset"=>11}],
"text": "una anotacion"
}},
xhr: true
end.to_not change { @draft_version.annotations.count }
end
it "creates an annotation by parsing parameters in JSON" do
sign_in @user
expect do
xhr :post, :create, process_id: @process.id,
draft_version_id: @draft_version.id,
legislation_annotation: {
"quote" => "ipsum",
"ranges" => [{"start" => "/p[1]", "startOffset" => 6, "end" => "/p[1]", "endOffset" => 11}].to_json,
"text": "una anotacion"
}
post :create, params: {
process_id: @process.id,
draft_version_id: @draft_version.id,
legislation_annotation: {
"quote"=>"ipsum",
"ranges"=>[{"start"=>"/p[1]", "startOffset"=>6, "end"=>"/p[1]", "endOffset"=>11}].to_json,
"text": "una anotacion"
}},
xhr: true
end.to change { @draft_version.annotations.count }.by(1)
end
@@ -88,14 +96,16 @@ describe Legislation::AnnotationsController do
sign_in @user
expect do
xhr :post, :create, process_id: @process.id,
draft_version_id: @draft_version.id,
legislation_annotation: {
"quote" => "ipsum",
"ranges" => [{"start" => "/p[1]", "startOffset" => 6, "end" => "/p[1]", "endOffset" => 11}],
"text": "una anotacion"
}
end.not_to change { @draft_version.annotations.count }
post :create, params: {
process_id: @process.id,
draft_version_id: @draft_version.id,
legislation_annotation: {
"quote"=>"ipsum",
"ranges"=>[{"start"=>"/p[1]", "startOffset"=>6, "end"=>"/p[1]", "endOffset"=>11}],
"text": "una anotacion"
}},
xhr: true
end.to_not change { @draft_version.annotations.count }
expect(annotation.reload.comments_count).to eq(2)
expect(annotation.comments.last.body).to eq("una anotacion")