consul/grecia
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Add and apply Capybara/RSpec/HaveSelector rule

Browse Source 
This rule was added in rubocop-capybara 2.19.0. We were following it
about 85% of the time.

Now we won't have to check both have_css and have_selector when
searching the code.
This commit is contained in:
Javi Martín
2023-10-03 18:35:51 +02:00
parent 83f3cbc143
commit 0cec581ec0
53 changed files with 206 additions and 203 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
spec/system/site_customization/custom_pages_spec.rb
View File

@@ -15,7 +15,7 @@ describe "Custom Pages" do
visit custom_page.url
expect(page).to have_title("Custom page")
expect(page).to have_selector("h1", text: "Custom page")
expect(page).to have_css "h1", text: "Custom page"
expect(page).to have_content("Text for new custom page")
expect(page).not_to have_content("Print this info")
end
@@ -33,8 +33,8 @@ describe "Custom Pages" do
visit custom_page.url
expect(page).to have_title("Custom page")
expect(page).to have_selector("h1", text: "Custom page")
expect(page).to have_selector("h2", text: "This is my new custom page")
expect(page).to have_css "h1", text: "Custom page"
expect(page).to have_css "h2", text: "This is my new custom page"
expect(page).to have_content("Text for new custom page with a link to https://consul.dev")
expect(page).to have_link("https://consul.dev")
expect(page).to have_content("Print this info")
@@ -53,9 +53,9 @@ describe "Custom Pages" do
visit custom_page.url
expect(page).to have_title("Custom page")
expect(page).to have_selector("h1", text: "Custom page")
expect(page).to have_css "h1", text: "Custom page"
expect(page).to have_content("Text for new custom page")
expect(page).not_to have_selector("h2")
expect(page).not_to have_css "h2"
expect(page).not_to have_content("Print this info")
end
@@ -88,7 +88,7 @@ describe "Custom Pages" do
visit custom_page.url
expect(page).to have_title("Another custom page")
expect(page).to have_selector("h1", text: "Another custom page")
expect(page).to have_css "h1", text: "Another custom page"
expect(page).to have_content("Subtitle for custom page")
end