consul/grecia
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Add and apply Capybara/RSpec/HaveSelector rule

Browse Source 
This rule was added in rubocop-capybara 2.19.0. We were following it
about 85% of the time.

Now we won't have to check both have_css and have_selector when
searching the code.
This commit is contained in:
Javi Martín
2023-10-03 18:35:51 +02:00
parent 83f3cbc143
commit 0cec581ec0
53 changed files with 206 additions and 203 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
spec/system/advanced_search_spec.rb
View File

@@ -235,7 +235,7 @@ describe "Advanced search" do
click_button "Filter"
within ".advanced-search-form" do
expect(page).to have_selector("input[name='search'][value='Schwifty']")
expect(page).to have_css "input[name='search'][value='Schwifty']"
expect(page).to have_select("By SDG", selected: "7. Affordable and Clean Energy")
expect(page).to have_select("advanced_search[date_min]", selected: "Last 24 hours")
end
@@ -255,10 +255,10 @@ describe "Advanced search" do
within ".advanced-search-form" do
expect(page).to have_select "advanced_search[date_min]", selected: "Customized"
expect(page).to have_selector "input[name='advanced_search[date_min]']" \
"[value*='#{7.days.ago.strftime("%d/%m/%Y")}']"
expect(page).to have_selector "input[name='advanced_search[date_max]']" \
"[value*='#{1.day.ago.strftime("%d/%m/%Y")}']"
expect(page).to have_css "input[name='advanced_search[date_min]']" \
"[value*='#{7.days.ago.strftime("%d/%m/%Y")}']"
expect(page).to have_css "input[name='advanced_search[date_max]']" \
"[value*='#{1.day.ago.strftime("%d/%m/%Y")}']"
end
end
end